I'm getting this because fb_user_get_local_user_by_email() is calling user_load(array('mail' => $email)) on l. 1042 of fb_user.module, which doesn't jive with the signature of the user_load method.

CommentFileSizeAuthor
#5 1064250-fb-user-load-fixes.patch863 bytesdave reid
#3 fb_user.module.patch630 bytesMeriial

Comments

Meriial’s picture

Meriial commented

user_load_by_mail() is the correct function to call.

I'm new to helping out. Should I make a patch?

Dave Cohen’s picture

Dave Cohen commented

I guess that changed going from D6 to D7. Thanks for the report. ANd yes a patch would be ideal. That makes it easiest for me to include the change. And its good practice. :)

Meriial’s picture

Meriial commented
StatusFileSize
new fb_user.module.patch630 bytes

Here is a patch, let me know if there are any problems with it.

steven jones’s picture

steven jones commented
Status: Active » Reviewed & tested by the community

Fixes the issue for me, and the patch looks good.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 1064250-fb-user-load-fixes.patch863 bytes

There is another user_load() call that is missing a fix.

jessepinho’s picture

jessepinho commented

Thanks Dave Reid—fixed it for me!

franzkewd’s picture

franzkewd commented

Thanks.

Dave Cohen’s picture

Dave Cohen commented
Status: Needs review » Fixed

Thanks for that!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.