Unknown column 'n.language' in 'where clause' query

Please try the attached fix.

Note: update.php has to be run because this new version changes the schema.

@kirsh: can you roll a patch?
see: http://drupal.org/patch

ad-thanks-vance!

Please find attached the .patch files generated from thread #1.

The changes made by kirsh seem to have fixed the problem described on this issue ( column 'n.language' ) but now when enabling any module (admin/build/modules) I get this:

user warning: Unknown column 'i.type' in 'where clause' query: SELECT f.field_name FROM content_node_field f, content_node_field_instance i WHERE f.field_name = i.field_name AND f.type = 'serial' AND i.type = 'image' in ...\sites\all\modules\_cck\serial\serial.inc on line 51.

Are you folks able to give any light on this? :) Cheers

@kirsh, is it possible to separate the bugfix from additional patches you did?
that might brighten the life of the maintainer as well as that of helpful folks.

well, just notices you *are* the maintainer.

@francisco: yes this *is* a bug, as of the schema it must be "i.type_name" (may not make sense, but schema sais it).

strange that you get that at module enable time (really any module?) because that line should only fire when a content type is renamed.

ok fixed that (untested!) on top of kirsh's version from #1 and put it in my sandbox for all that have interest or further patches:
http://drupal.org/sandbox/axel.rutz/1154028

@axel.rutz #6
Well then it might be cache related. I mean, perhaps the error is not issued on every module enabling process but it gets printed out because it is cached or something. Just a guess!!!
When I get a chance I will re-test it.

subscribing

Whenever I clear my cache with drush, I get the following (twice):

WD php: Unknown column 'n.language' in 'where clause' [error]
query: SELECT f.field_name FROM content_node_field f, content_node_field_instance i WHERE (n.language ='nl' OR n.language ='' OR n.language IS NULL) AND ( f.field_name = i.field_name AND f.type = 'serial' AND i.type_name = 'blog') in /home/diederik/Openbaar/dev/wonen-en-werken.statiklabs.be/sites/all/modules/serial/serial.inc on line 49.
WD php: Unknown column 'n.language' in 'where clause'

it would really be great to understand under what conditions multilang (which module?) rewrites the sql.
my naive guess would that it checks if the node table is involved... but that is clearly not the case in serial.inc:49.

edit: here is a good explanation what happens. as we do not have a "db_rewrite_sql" in that function anymore i ask you, zilverdistel, to check if your source is the same as that in the link above. (if not you owe us a beer ;-)

@axel.rutz: I guess I owe you a beer after all. Removing the db_rewrite_sql call fixed the problem with drush cc all.

Has this been committed in dev allready?

please, please ... can we have a release with this solved ...

Subscribing.

#7 @axel.rutz Thanks, your fix seems to be working fine. It also fixed the cache issue. I applied it into my code with serial fields working and it continues to work without issues. I haven't tried renaming the field though.

I think this can be marked RTBC ...

Adding tag.

I don't see a patch here with the most recent fix. Is this even still a problem? It looks like at least some of the code is already in the dev version. Can someone confirm? I no longer have D6 running.

If it's still a problem, please provide the individual fix in patch format that applies to the current dev branch.

As nobody's complained, I'll assume that this is no longer an issue.

This unfortunately continues to be an issue. After updating core to 6.30, I am getting the same error message for i.types 'blog' and 'panel'