Download & Extend
Zen » Issues

Terminate CSS comment in layout.css

Posted by RobRoy on January 2, 2007 at 9:51pm
Project:Zen
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:minor
Assigned:rport
Status:closed (fixed)

Issue Summary

Is the unterminated /* in layout.css intentional? If so it should be commented, if not let me know and I'll submit a patch.

Login or register to post comments

Comments

#1

Posted by alanburke on January 16, 2007 at 10:18pm

Looks like cruft to me
Should have been commented if it were needed.
Roll away...

#2

Posted by jjeff on January 17, 2007 at 4:44am

I'm not seeing this. Can you give me a line number or a context?

#3

Posted by rport on January 29, 2007 at 1:28pm
Assigned to:Anonymous» rport
Status:active» needs review

Hmm...

A quick look at layout.css shows this exists on or near line 96 (the very bottom) its a quick fix, i've attached a patch for review.

rport

AttachmentSize
layout-070129.patch 188 bytes

#4

Posted by BioALIEN on February 18, 2007 at 6:39pm

Has this been committed yet?

#5

Posted by plhosk on February 20, 2007 at 2:00am

This patch, which effectively uncomments the bottom 3 lines of layout.css, breaks the footer in the zen-fixed theme. It causes the footer to take up as much space as in the zen non-fixed theme.

#6

Posted by rport on February 22, 2007 at 8:43am

I suspect from reading this that the area affected should have been commented out however the terminating */ was left out (see below).

Here is a copy of the relevant section of code;

/*
body.sidebar-left  #footer {
  margin-left: -210px;
}

body.sidebar-right #footer {
  margin-right: -210px;
}

body.both-sidebars #footer {
  margin: 0 -210px;
}

Over to jjeff to consider this and resolve the matter...

  1. Is this some legacy code that should be removed, not just commented out; or
  2. Is this css for some new feature/idea that is simply missing the block terminator; or

~ rport

#7

Posted by jacauc on February 22, 2007 at 2:06pm

Subscribing

#8

Posted by dmitrig01 on May 6, 2007 at 12:07am
Version:6.x-1.x-dev» 5.x-1.x-dev

Here is a proper patch. Works in both fixed and full modes.

AttachmentSize
zen-comment-close.patch 568 bytes

#9

Posted by add1sun on May 6, 2007 at 2:12pm
Status:needs review» fixed

committed to 5 dev

#10

Posted by Anonymous on May 20, 2007 at 2:31pm
Status:fixed» closed (fixed)