Is the unterminated /* in layout.css intentional? If so it should be commented, if not let me know and I'll submit a patch.

CommentFileSizeAuthor
#8 zen-comment-close.patch568 bytesdmitrig01
#3 layout-070129.patch188 bytesrport

Comments

alanburke’s picture

Looks like cruft to me
Should have been commented if it were needed.
Roll away...

jjeff’s picture

I'm not seeing this. Can you give me a line number or a context?

rport’s picture

Assigned: Unassigned » rport
Status: Active » Needs review
StatusFileSize
new188 bytes

Hmm...

A quick look at layout.css shows this exists on or near line 96 (the very bottom) its a quick fix, i've attached a patch for review.

rport

BioALIEN’s picture

Has this been committed yet?

plhosk’s picture

This patch, which effectively uncomments the bottom 3 lines of layout.css, breaks the footer in the zen-fixed theme. It causes the footer to take up as much space as in the zen non-fixed theme.

rport’s picture

I suspect from reading this that the area affected should have been commented out however the terminating */ was left out (see below).

Here is a copy of the relevant section of code;

/*
body.sidebar-left  #footer {
  margin-left: -210px;
}

body.sidebar-right #footer {
  margin-right: -210px;
}

body.both-sidebars #footer {
  margin: 0 -210px;
}

Over to jjeff to consider this and resolve the matter...

  1. Is this some legacy code that should be removed, not just commented out; or
  2. Is this css for some new feature/idea that is simply missing the block terminator; or

~ rport

jacauc’s picture

Subscribing

dmitrig01’s picture

Version: 6.x-1.x-dev » 5.x-1.x-dev
StatusFileSize
new568 bytes

Here is a proper patch. Works in both fixed and full modes.

add1sun’s picture

Status: Needs review » Fixed

committed to 5 dev

Anonymous’s picture

Status: Fixed » Closed (fixed)