Closed (fixed)
Project:
Zen
Version:
5.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Reporter:
Created:
2 Jan 2007 at 21:51 UTC
Updated:
20 May 2007 at 14:31 UTC
Jump to comment: Most recent file
Is the unterminated /* in layout.css intentional? If so it should be commented, if not let me know and I'll submit a patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | zen-comment-close.patch | 568 bytes | dmitrig01 |
| #3 | layout-070129.patch | 188 bytes | rport |
Comments
Comment #1
alanburke commentedLooks like cruft to me
Should have been commented if it were needed.
Roll away...
Comment #2
jjeff commentedI'm not seeing this. Can you give me a line number or a context?
Comment #3
rport commentedHmm...
A quick look at layout.css shows this exists on or near line 96 (the very bottom) its a quick fix, i've attached a patch for review.
rport
Comment #4
BioALIEN commentedHas this been committed yet?
Comment #5
plhosk commentedThis patch, which effectively uncomments the bottom 3 lines of layout.css, breaks the footer in the zen-fixed theme. It causes the footer to take up as much space as in the zen non-fixed theme.
Comment #6
rport commentedI suspect from reading this that the area affected should have been commented out however the terminating */ was left out (see below).
Here is a copy of the relevant section of code;
Over to jjeff to consider this and resolve the matter...
~ rport
Comment #7
jacauc commentedSubscribing
Comment #8
dmitrig01 commentedHere is a proper patch. Works in both fixed and full modes.
Comment #9
add1sun commentedcommitted to 5 dev
Comment #10
(not verified) commented