'Display number of items': Node count should include descendants

Thanks, why don't you reroll it with an administrative option to include descendants or not.

The original patch works but then makes the taxonomy_term_count_nodes() call redundant. My attached patch does a couple things:

• creates a new setting display_num_descendants, not to be confused with display_descendants. This setting will include the count of descendant nodes using the core taxonomy module's taxonomy_term_count_nodes function if display_num is also set.
• changes the description for display_descendants to reflect it applies to changing the path

Here's a chart of possible options. There may be more permutations:

Patched against 6.x-2.x-dev (2011-Dec-02).

Changing status to needs review

Marked #1337012: hierarchical taxonomy counts as a duplicate.
It contains a different solution. Not sure if it is better or compatible:

somewhere in function _taxonomy_menu_item there should perhaps be something like this:

	if ($num == 0) {
		$terms=_taxonomy_term_children($item['tid']);
		out($terms);
		foreach ($terms as $tid) {
			$num=$num+taxonomy_term_count_nodes($tid);
		}
	}

this way, the parent terms menu items of a hierachy will have a number that is the sum of the count of the children instead of (0) as is now.

These are duplicates, but have different solutions to the problem:
#1064510: 'Display number of items': Node count should include descendants
#784022: 'Display number of items': (incl. child terms), but do not group descendants

Attached patch adds a new checkbox "Include items belonging to child terms in number counts" (defaults to disabled) which enables the inclusion of child terms' items in the node count.

Patch by stewart.adam works perfectly fine.

Please ignore previous post - one issue I am facing with stewart.adam's patch is that if the term reference node is deleted - the counter doesn't change for parent term, but only changes for child term.

To make sure I understood correctly:

• Taxonomy term structure is Parent -> Child
• Node 1 is tagged with term "Parent"
• Node 2 is tagged with term "Child"

In this scenario deleting Node 2 updates the counter for the Child but not Parent term?

The patch #7 is only working for the first child...

Eg. if I have this structure (standard "display number of items"):

-> Main (0)
     -> Sub1 (5)
     -> Sub2 (0)
          -> SubSub1 (3)
          -> SubSub2 (2)
    -> Sub3 (5)

the patch shows "Main (10)", so it doesn't count SubSub1 and SubSub2...

Besides this, I think the number of items should be shown like this:

-> Main (0/15)
     -> Sub1 (5)
     -> Sub2 (0/5)
          -> SubSub1 (3)
          -> SubSub2 (2)
    -> Sub3 (5)

Hello from Drupal's GSoC 2014 team. Google Summer of Code (GSoC)? - an annual program for university students organized by Google with projects managed by open source organization mentors such as us (Drupal!).

We're currently browsing the issue queue looking for projects. Do you think this issue/project is worth a student spending a summer on it and being paid by Google? If so, are you interested in mentoring the student? Learn more about Summer of Code and how to get involved at links below. We're submitting our Summer of Code application to Google in just over 24 hours and looking for last minute ideas. Please respond quickly if you're interested.

Group to join - https://groups.drupal.org/google-summer-code

Ideas for projects for Summer of Code 2014 - https://groups.drupal.org/node/404778

GSoC Homepage http://www.google-melange.com/gsoc/homepage/google/gsoc2014

Google's Summer of Code 2014 Announcement - http://google-opensource.blogspot.com/2014/02/mentoring-organization-app...

This patch already in 2 years ago and none of solution come out to let it commit in current version. Or does it plan to move into new major version?

I patch and it works successfully.

Hello,
I'm just thinking if taxonomy_get_tree() wouldn't be better instead of taxonomy_get_children()?
So

$terms = taxonomy_get_tree($item['vid'], $item['tid']);

instead of

$terms = taxonomy_get_children($item['tid']);

Any updates here?

My patch.
New option like in #7 with correct update node counts in parent terms (see #9)

Before mark as tested this logic must moved in taxonomy_menu_translated_menu_link_alter() allso.

#17 worked for me and I applied the same logic into function taxonomy_menu_translated_menu_link_alter() and it also worked.

Made patch from #17 apply against latest dev version. Applied the same concept to taxonomy_menu_translated_menu_link_alter().

Would it be possible to commit the patch in #19 to 7.x-1.x-dev and tag a 7.x-1.6 release? Maybe some of the patches that need review can get in this release as well.

For me its ok, I have commited the last patch but will be good if smn can double check it.