Another one (much less important) :
The following code :

db_query("CREATE TABLE {foo} (
  bar varchar(32),
  ) TYPE=MyISAM /*!40100 DEFAULT CHARACTER SET utf8 */;");

triggers "do not use mixed case (camelCase), use lower case and _"

This is also true with :

"aa
aaAaa"

Comments

douggreen’s picture

douggreen commented
Assigned: Unassigned » douggreen

I checked in a patch to the development branch. Could you please check it out. The regex changes are kindof difficult, so if possible, could you run a few additional tests on this just to make sure I didn't muck up something that used to work.

yched’s picture

yched commented

This seems right, now.

A strange thing however :
in order to test this, I added 

"aa
aAaa";

in one of my files.
Code review then triggers "camelCase" on a completely unrelated part 200 lines below.

Same thing with :

$a =
"aa
aAaa";

This seems to happen only if the opening " is the first character on the line.

$a = "aa
aAaa";

and

 "aa
aAaa";

(whitespace or indentation tab before "aa)
seem to be OK

douggreen’s picture

douggreen commented

Yea, that makes sense - the regex's generally check the character before the quote to make sure it's not another quote or a backslash \. I'm not sure how easy this will be to fix or that if anyone will really write the type of code you just did, that by itself, would be bad style. Is it OK to close the ticket?

yched’s picture

yched commented
Status: Active » Fixed

Yes, i guess so.

douggreen’s picture

douggreen commented

This has actually fixed in subsequent releases. If you'd like to test and confirm this, I'll close the ticket.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)