Closed (outdated)
Project:
Drupal core
Version:
7.x-dev
Component:
batch system
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 Feb 2011 at 18:54 UTC
Updated:
8 Aug 2014 at 12:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mile23It might help to know which module.
Comment #2
bfroehle commentedAlso, is this a consistent, reproducible problem? Or does it occur only transiently?
Comment #3
pixelsweatshop commentedIt happens on 80% of the modules I have installed. I will do a test to see which ones it occurs on. I didn't take note as it appeared to happen on almost everyone. All modules still continue to install though.
Comment #4
bfroehle commentedSo the module installs correctly, but you see this error at the very end? Can you walk me through the timeline of the installation process and where exactly you see the error?
Also, do you using the Overlay module, or have that module enabled?
Comment #5
Eduardo_Martinez commentedI have also the same error. is seems a problem with AJAX, because I can see, few seconds, an AJAX error message when some new modules are updating or new languages packs.
Comment #6
sunSorry, without further information this issue can only be closed as not reproducible.
Feel free to re-open this issue if you want to provide further information. Thanks.
Comment #7
sunComment #8
ericvermeulen commentedHi There I have te same issue on the installation of Drupal 7.2. The actual installation seems to be finished as the percentage bar is at 100% and when I open the drupal site which has been installed I get the login screen. the actual error message is: Notice: Undefined variable: finished in _batch_process() (line 345 of D:\XXXYYYZZZ\includes\batch.inc). next step is to configure the site, but I don't get to that stage. please advise.
Eric
Comment #9
ericvermeulen commentedHi There, I ran the install through the UI again and for some strange reason the error has disappeared, this is really wicked.
Cheers,
Eric
Comment #10
JSCSJSCS commentedI too am seeing this error in nearly all updates using the UI. Lat one was updating the VBO module. After the Update UI did it;s thing and it says to go to database update, there is a quick AJAX alert that flashes. I was able to capture it (see attached). Then the log shows:
Type php
Date Sunday, July 17, 2011 - 07:35
User admin
Location http://mydrupaljourney.com/authorize.php?batch=1&render=overlay&id=32&op=do
Referrer http://mydrupaljourney.com/authorize.php?batch=1&op=start&id=32&
Message Notice: Undefined variable: finished in _batch_process() (line 344 of /home/username/mydrupaljourney.com/includes/batch.inc).
Severity notice
Line 344 of includes/batch.inc:
$current = $total - $remaining + $finished;
Comment #11
LarsKramer commented@JSCSJSCS: Can you reproduce this error on a completely fresh Drupal 7.4 installation with only VBO installed, and overlay.module disabled? From which version of VBO did you update?
Comment #12
jimbaer commentedJust had this flash of an Ajax error when downloading/installing upgrades for Chaos tools and Backup Migrate on a D7.4 installation. Ajax error screen was only present very briefly, not possible to see what it said. Updates appear to have been correctly installed, and both appear to be operating correctly. No error messages logged on Drupal reports.
Comment #13
LarsKramer commented@jimbaer: Can you reproduce this using the steps described in #11: No other modules installed, and overlay disabled?
Comment #14
jcuzella commentedI am able to reproduce this on a fresh install when doing an upgrade from 7.0 to 7.4 on a site that was previously upgraded from 6.20.
Steps to reproduce:
1. Install Drupal 6.20
2. Manually upgrade all files to Drupal 7.0
3. Run update.php
4. Manually upgrade all files to Drupal 7.4
5. Run update.php
I see this error displayed on the "/update.php?op=results" page:
Notice: Undefined variable: finished in _batch_process() (line 344 of /var/www/includes/batch.inc).
Comment #15
jimbaer commentedLars,
I can no longer raise this error. As far as I can see the only change made to my configuration in between not allowed for was removal of mod_security Apache module by my host to cure some jquery.cookie.js access problems.
I'm not confident enough to say that's the cause though, since I'm a bit of a novice at this stuff, and may have missed another change when fiddling with .htaccess to make a sub-domain work.
Comment #16
LarsKramer commentedI managed to reproduce this finally, but so far only with Google Chrome, and Drupal 7.7. The problem seems to have been solved in 7.x-dev. I tested with Views and i18n, but it seems to happen with any module.
The steps to reproduce are:
If you then delete the module folder and restart the browser, you can follow the same steps and the message will come again. You have to restart the browser, otherwise no message shows. I never enabled the module.
I tried this also in Firefox and IE, but was not able to reproduce there, so it might be a problem isolated to Google Chrome. On the other hand, it is strange then that it does not occur when using Drupal 7.x-dev.
Comment #17
LarsKramer commentedJust tested with overlay.module disabled, and then the message no longer shows. So I guess the bug is in overlay.module, not update.module.
Comment #18
David_Rothstein commentedSounds like this is at least partially a duplicate of #936686: "Installation failed" errors when installing modules from Update Manager w/ Overlay (which was fixed in 7.x-dev shortly after the 7.7 release so that would go along with what @LarsKramer found) but I'm not sure if all of it is... there are several reports in this issue that don't quite seem to be about the same thing.
Comment #19
webchickI'm 99% positive this is a duplicate of #936686: "Installation failed" errors when installing modules from Update Manager w/ Overlay. Try updating to 7.x-dev and see if you have the same issue.
Comment #20
Mithrandir commentedThe notice comes from includes/batch.php's _batch_process() function that uses $finished and $old_set variables, which are only set, if $current_set['success'] is FALSE.
We see the errors when using any batch operation while the has_js cookie is not set (e.g. using standard Varnish configuration), so I assume that in those cases, we end up running _batch_process() at a point in time where $current_set['success'] is TRUE, but the batch is not completely finished.
Either way, with sane variable initialisation, these notices should go away without further logical problems.