Allow fetcher to specify among the possible metadata formats offered by the repository

Hi , i try patch and i get this :

patch -p0 < feeds_oai_pmh-1065452-metadata-formats.patch
patching file FeedsOAIHTTPFetcher.inc
patching file feeds_oai_pmh.inc
Hunk #1 FAILED at 8.
Hunk #2 FAILED at 54.
Hunk #3 FAILED at 63.
Hunk #4 FAILED at 180.
Hunk #5 FAILED at 220.
5 out of 5 hunks FAILED -- saving rejects to file feeds_oai_pmh.inc.rej
patching file feeds_oai_pmh.module

why is it happening ?

Oh Thank!

I applied on last dev. My apologise.

Hi,

With XML Schema and template parser i think it's possible accept more formats.

I agree, however, using the ahah approach for selecting the metadata format similar to how it selects a setSpec works nicely for constructing the ListRecords request. Of course, the request is just fetching the raw data, and if the content is oai_dc, or mets, or rdf it still needs an appropriate parser to handle it.

I couldn't get this patch to work. It doesn't seem to be constructing the FeedsOAIHTTPFetcher with the metadata_prefix from the form element and results in a request url with &metadataPrefix= without a value for the attribute.

When I uncommented the dsm statement in FeedsOAIHTTPFetcher which displays the URL a portion of it looks like this...

....?verb=ListRecords&metadataPrefix=&from=....

I applied the patch from comment #9 to the 6.x-1.x-dev and the fetcher is working. I first attempted to leave the HTTP OAI-PMH Fetcher metadataPrefix setting to "oai_dc" and run a feeds import with oai_dc. The oai_dc import was a success. A second test was performed by changing the metadataPrefix to mets and updating the OAI Parser to map the "Repository Record Identifier" as this field is located in the record head of both oai_dc and mets returns. The Fetcher and limited Parsing also imported successfully for mets.

With my test the HTTP OAI-PMH Fetcher is working successfully, but the OAI Parser needs to be extended to map other metadata fields like mets, nsdl_dc and rdf.

Would it be cleaner to have a separate feature request to extend the OAI Parser?

I did find one PHP warning when running the import as metadataPrefix=mets a second time when no new content is found. The php warning: "warning: Invalid argument supplied for foreach() in /sites/all/modules/feeds_oai_pmh/FeedsOAIParser.inc on line 38."

When I check if the array_key_exists before running the foreach loop the warning goes away.

          if (array_key_exists('setspec_raw', $result['items'])){
            foreach ($item['setspec_raw'] as $setspec) {
              $set_name = $identify_response['repository']['sets'][$setspec]['name'];
              $result['items'][$index]['setspec_name'][] = $set_name;
            }
          }

Not sure the warning is limited to this code addition, but it is probably a good idea to perform a check on the array key anyway.

Looks like head has been updated so I am attaching updated patches for compatibility. I am also rolling a patch for the 7 branch.

Branch 7 patch in #14 is incorrect so i am attaching a update.

Updated patch for current HEAD.