Despite the fact that the Drupal module world usually contains thousands of modules that do the same thing, this module provides a good solution to the modal box login. We ran into a problem with lightbox2, thickbox, and colorbox login conflicting with Varnish on a production server. Because this module uses path aliasing to handle the loading of the widget it works on our setup. This is great. Good work.

I wanted to suggest two minor theming changes. One that in fancy_login.css on line 87:

#user-login .form-text, #user-pass .form-text { ...

Possibly change to be more specific, not affecting the normal form at /user/login

#fancy_login_login_box #user-login .form-text,#fancy_login_login_box #user-pass .form-text { ...

Seems odd to implement module, and then have to add css to return my user login form to normal.

Second, consider tying the width of the modal to the admin form setting of the width. Seems odd to increase the width of the modal, and have the inputs stay exactly the same. Again, my work flow was
implement module, configure module css, change external css. Thanks for the nice module.

CommentFileSizeAuthor
#2 fancy_login.css#1066018.patch382 bytesiva2k

Comments

jaypan’s picture

That's some really good feedback, much appreciated. I'll integrate your suggestions into the next version of the module.

iva2k’s picture

Status: Active » Needs review
StatusFileSize
new382 bytes

Here's a patch for this. People, please review and RTBC.

jaypan’s picture

Issue summary: View changes
Status: Needs review » Fixed

Thank you for the patch. However, I've decided to drop support of Version 6.x-1.x in favor of version 6.x-2.x which is a backport of version 7.x-3.x. In this version I've prefixed all CSS with either #fancy_login or .fancy_login, so this issue should not longer be an issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.