Needs review
Project:
Ubercart Views
Version:
6.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
19 Feb 2011 at 02:57 UTC
Updated:
16 Feb 2013 at 15:27 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
laken commentedBump - can anyone review my patch?
Comment #2
hanoiigot your mail, will try to review it when I have a chance, quite busy at the moment.
Comment #3
charlie-s commentedThis is awesome, taking a look now.
Comment #4
charlie-s commentedIn uc_views_handler_field_payment_txn_id.inc it was returning an empty value for me. My transaction ID was coming from PayPal if that has anything to do with anything.
I changed
return parent::render($values);to
return $payment->comment;and am getting the transaction ID that I need. Thank you very much for providing this code.
Comment #5
m.stentaWow! Thank you so much for this. Really saved me some time today.
I rerolled the patch from root folder of the the latest dev snapshot (to comply with patching standards: http://drupal.org/node/707484).
I did not factor in the changes suggested in #4 above because I'm not sure how that would affect non-PayPal payments. Someone should do some testing with that, or maybe see if there's already another issue with the way PayPal payments are registered (perhaps it doesn't follow the correct rules in the first place?).
Attached is the new patch.
Comment #6
jvieille commentedEdit: $data['uc_payment_receipts']['receipt_id'] = array( needs a numeric handler for the filter (It used to work, but suddenly broke!)
Thanks for submitting this.
Bellow the code that works with Ubercart standard - the tx part of this patch seems specific, this did not match my configuration
Bellow the code that was helpful for me, i.e including the payment method that missed and removing the transaction stuff. Only the file uc_views.views.inc is affected