Only author can vote after upgrade

Posted by jmpalomar on February 20, 2011 at 12:20pm

17 followers

Issue Summary

Hi,

I've upgraded form version 2.6 to version 2.7 today and after that voting button only appears to authors of node when they are allowed to vote.

After reviewing the code I see that in plus1.module in function theme_plus1_widget line 428:

  elseif (user_access('vote on content')) {
    // Is this the user's own content and do we allow them to vote on it?
    if ($is_author && variable_get('plus1_vote_on_own', 1)) {
      if ($vote_text = variable_get('plus1_vote', 'Vote')) {
        // User is eligible to vote.
        // The class name provided by Drupal.settings.plus1.vote_class what
        // we will search for in our jQuery later.
        $output_content .= '<form class="' . $vote_class . '" action="'
          . url("plus1/vote/$node->nid",
            array('query' => 'token=' . drupal_get_token($node->nid) . '&' . drupal_get_destination()))
          . '" method="post"><div>';

        $output_content .= '<button type="submit"><span>' . t(filter_xss_admin($vote_text)) . '</span></button>';

        $author_text = variable_get('plus1_author_text', 'Your content');
        if ($author_text) {
          $output_content .= '<div class="plus1-author-text">' . t(filter_xss_admin($author_text)) . '</div>';
        }

        $output_content .= '</div></form>';
      }
    }

With condidion $is_author && variable_get('plus1_vote_on_own', 1) button is noly rendered when user is author an athors can vote own content.

I changed this code for this and everything seems to work again:

  elseif (user_access('vote on content')) {
    // Is this the user's own content and do we allow them to vote on it?
    if (!$is_author || ($is_author && variable_get('plus1_vote_on_own', 1))) {
    
      $vote_text = variable_get('plus1_vote', 'Vote');	
      if ($vote_text) {
        // User is eligible to vote.
        // The class name provided by Drupal.settings.plus1.vote_class what
        // we will search for in our jQuery later.
        $output_content .= '<form class="' . $vote_class . '" action="'
          . url("plus1/vote/$node->nid",
            array('query' => 'token=' . drupal_get_token($node->nid) . '&' . drupal_get_destination()))
          . '" method="post"><div>';

        $output_content .= '<button type="submit"><span>' . t(filter_xss_admin($vote_text)) . '</span></button>';

        $output_content .= '</div></form>';
      }
      
    }
    else if($is_author && !variable_get('plus1_vote_on_own', 1)) {
        $author_text = variable_get('plus1_author_text', 'Your content');
        if ($author_text) {
          $output_content .= '<div class="plus1-author-text">' . t(filter_xss_admin($author_text)) . '</div>';
        }
    }
  }

Comments

#1

Posted by Code Rader on February 24, 2011 at 4:37am

Component:

User interface

» Code

Yes, this is a critical bug. I didn't have authors enabled to vote so no one could vote on anything anymore. The above code works. It needs to be put into a patch though.

#2

Posted by hamsterbacke82 on March 17, 2011 at 8:44am

Thanks a lot for this solution, had the same problem and thought I was too stupid to set up the module correctly

#3

Posted by saml on March 22, 2011 at 1:21pm

Thanks for the patch jmpalomar! ... only that now there is a big "ugly" vote button instead of the up-arrow, that was used before ... but maybe one can find the old theming code again and use it ... I might try this ...

#4

Posted by jonathanpglick on March 22, 2011 at 7:20pm

Status:

active

» needs review

I ran into this problem and the above changes worked for me. Attached is a patch of the changes so it'll hopefully be easier to get into the codebase.

Attachment	Size
plus1-only_author_vote-1067244-4.patch	990 bytes

#5

Posted by codycraven on April 6, 2011 at 8:18pm

Status:

needs review

» reviewed & tested by the community

This is ridiculously critical it completely breaks the module. The patch in #4 works fine.

#6

Posted by NancyDru on April 7, 2011 at 1:12am

Okay. Do you know Git well enough to show me how?

#7

Posted by codycraven on April 7, 2011 at 2:36pm

Here are the commands you need (this should all be listed for you here):

First create a clone from git:

git clone --branch 6.x-2.x http://git.drupal.org/project/plus1.git
cd plus1

Then (I don't think this step is necessary after a fresh clone but might as well do it since I'm not a git expert) ensure you are on the right branch.

git checkout --track origin/6.x-2.x
git pull origin 6.x-2.x

Now apply your patch

git apply [patch.name]
rm  [patch.name]

Commit the changes

git add -A
git commit -m "Issue #[issue number] by [comma-separated usernames]: [Short summary of the change]."

Push it back to the Drupal.org repository so it shows up on Drupal.org

git push origin 6.x-2.x

Then to tag a release when ready, you would swap 8 in to [minor version here] since that would be the next version.

git checkout  6.x-2.x
git tag 6.x-2.[minor version here]
git push origin 6.x-2.[minor version here]

#8

Posted by NancyDru on April 7, 2011 at 3:10pm

Thanks. Many years ago there was no such thing as a GUI. Everything was done by CLI. Then Microsoft and Apple convinced the world to switch to GUIs. I was one who switched. I'm not excited by going back to CLI. I have tried to install Tortoise GIT, but so far I seem to be missing something. Perhaps I need to remove Tortoise CVS first.

#9

Posted by codycraven on April 7, 2011 at 4:17pm

I concur, seems like the Git GUIs I've used aren't exactly up to snuff with what's out there for CVS, SVN, or Mercurial.

#10

Posted by incrn8 on April 7, 2011 at 4:58pm

Hi Nancy,

I use Tortoise Git, but you have to install msysgit as well (this file to be exact: http://code.google.com/p/msysgit/downloads/detail?name=Git-1.7.3.1-previ...). Then, in TortoiseGit, go to Settings and set the Git.exe path to where you installed msysgit (C:\Program Files (x86)\Git\bin in my case). That got it all working for me.

There is a 1.7.4 msysgit version, but its a beta, so I didn't use it.

#11

Posted by john.karahalis on April 13, 2011 at 10:03pm

Hey Nancy.

You shouldn't need to use git to apply the patch. Just drop the patch into the module directory and run patch < plus1-only_author_vote-1067244-4.patch. Of course, committing and pushing the result of the patch will require git.

For the record, I don't know that this patch is perfect. It looks like it introduces a new bug regarding node ownership (see the screenshot). I did not see this bug in 2.6.

Attachment	Size
Bug? Plus 1 confused about the node ownership.	66.5 KB

#12

Posted by pivica on April 16, 2011 at 8:31am

Version:	6.x-2.7	» 6.x-2.x-dev
Status:	reviewed & tested by the community	» needs review

Here is a new patch builded against latest dev release - reused patch from #4, changed comments a little bit and fixed problem in #11.

Attachment	Size
plus1-only_author_vote-1067244-12.patch	1.91 KB

#13

Posted by firebus on April 26, 2011 at 4:51am

Status:

needs review

» reviewed & tested by the community

this patch works for me, and i'm not seeing any ownership issues (although it's not clear to me from #11 how to reproduce this issue...)

#14

Posted by john.karahalis on April 26, 2011 at 2:50pm

For #11, I did the following...

Steps:

Set some content type, say the "Story" content type, to be votable.
Log in with user John and create a Story node.
Log in with user admin and view the newly-created Story node.

Expected result:
Plus 1 does not indicate that the logged-in admin user owns the node.

Actual result:
Plus 1 does, mistakenly, indicate that the logged-in admin user owns the node.

Thanx!

#23

Posted by ezra-g on December 12, 2011 at 4:12pm

Status:

reviewed & tested by the community

» fixed

This is committed. Thanks!

http://drupalcode.org/project/plus1.git/commit/9392628

#24

Posted by System Message on December 26, 2011 at 4:20pm

Status:

fixed

» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Only author can vote after upgrade

Jump to:

Issue Summary

Comments

#1

#2

#3

#4

#5

#6

#7

#8

#9

#10

#11

#12

#13

#14

#15

#16

#17

#18

#19

#20

#21

#22

#23

#24

Project:	Plus 1
Version:	6.x-2.x-dev
Component:	Code
Category:	bug report
Priority:	critical
Assigned:	Unassigned
Status:	closed (fixed)