Hi. Is there a plan and timescale for a D7 release?

CommentFileSizeAuthor
#8 1067954.d7-upgrade-02.patch1.17 KBdrclaw
#6 1067954.d7-upgrade.patch480 bytesdrclaw

Comments

tebb’s picture

tebb commented

From the Domain (Domain Access) module readme file:

7.2 The $_domain Global

NOTE: In Drupal 7, this value is deprecated. You should use domain_get_domain()
to return the active domain.

xjm’s picture

xjm
she/her
Primary language English
commented

I don't have any immediate plans to create a new branch because I do not have any D7 sites at this time, but it should be fairly straightforward to port. If someone else comes up with a working port, I'll certainly open a new branch for it.

Stephen Rockwell’s picture

Stephen Rockwell commented

subscribing

cr0ss’s picture

cr0ss commented

I'll be very glad to help porting this module to D7.

xjm’s picture

xjm
she/her
Primary language English
commented

Go for it! Really it should only be a matter of:

  1. Running it through the code review module for D7 API changes
  2. Checking for DA API changes (like Drup-P's post in #1)
  3. Checking for Context or CTools API changes
  4. Patching for #1-3
  5. Updating the .info file for D7, including the files[] array business
  6. Last and most importantly, testing to make sure it works with DA, Context, and D7 core!

Feel free to do as much of this as you want. Then, go ahead and post the code in this issue (either an archive or a patch against 6.x-1.x-dev is fine).

Thanks!

drclaw’s picture

drclaw commented
Status: Active » Needs review
StatusFileSize
new 1067954.d7-upgrade.patch480 bytes

Here's a first attempt.

I fixed the info file and checked the context api for changes (of which it looked like there was none...)

Tested and it's working so far...

Is it possible it's this easy?

tebb’s picture

tebb commented

That's odd.

If #1 is still true, this should *not* be working, because the patch still references the deprecated global.

  function execute() {
    global $_domain;
    $domain_id = $_domain['domain_id'];
drclaw’s picture

drclaw commented
StatusFileSize
new 1067954.d7-upgrade-02.patch1.17 KB

It seems that the domain module still retains the $_domain global variable. 

function domain_get_domain() {
  if (isset($GLOBALS['_domain'])) {
    return $GLOBALS['_domain'];
  }
}

I suppose it's more in the process of deprecation. =P

Here's a new patch that uses the new function.

mortendk’s picture

mortendk commented

+1

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me! Edit: the D7 branch is open in git; I'll add the 7.x-1.x-dev build to the project page once the packaging script runs.

xjm’s picture

xjm
she/her
Primary language English
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Reviewed & tested by the community » Fixed

http://drupalcode.org/project/domaincontext.git/commit/a570f37

drclaw’s picture

drclaw commented

Good Stuff!

tebb’s picture

tebb commented

Many thanks DrClaw and XJM.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.