Hello
I think the title says it all actually...
On the account settings page (admin), I got an error that the Pictures directory was not writable. I decided I didn't need that feature so I unchecked the "enable user pictures" checkbox. When I submitted the form, the same error is thrown, Drupal is still checking the folder. So I tried to clear the pictures directory textbox, with the same result...
It is also very confusing that the textbox with the red border is actually hidden if you uncheck the "enable user pictures" checkbox.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | user-pictures-directory-check-1067964.patch | 2 KB | tayzlor |
| #2 | user-pictures-directory-check-1067964.patch | 2 KB | tayzlor |
Comments
Comment #1
jvandooren commentedMeanwhile, I found out that my entire files directory was not writable anymore... doing that made the account settings form create the pictures directory... But I still think Drupal shouldn't check the folder if the checkbox is unchecked...
Comment #2
tayzlor commentedI'm attaching a patch that moves the logic for validating the pictures directory to a separate form validation function and only fires if the user actually checked for picture support to be enabled.
I've replaced the form_set_error in the actual form above, with a drupal_set_message to show an error, in case the user came to this page and somehow their pictures directory was no longer writeable.
We might want to remove this altogether and just let it be handled in the validation function?
Comment #3
tayzlor commentedComment #4
tayzlor commentedre-uploading, whitespace and typo in original patch.
Comment #6
tayzlor commentedComment #7
tayzlor commented#4: user-pictures-directory-check-1067964.patch queued for re-testing.
Comment #8
kscheirer#4: user-pictures-directory-check-1067964.patch queued for re-testing.
Comment #9
kscheirerRetesting against latest HEAD since it has been over a year.
Comment #11
marcingy commentedUser pictures are now just a field in d8.