as cache_get returns the found cache items regardless of whether they are expired or not, twitter_pull shows outdated items. updating the cache won't work therefore and new cache entries will only be made when cron.php clears the cache table.

more information here: http://api.drupal.org/api/drupal/includes--cache.inc/function/cache_get/...

to fix this, we just have to check the expiration time when getting the cache. patch is attached.

patch is for 6.x.-1.2 but the bug affects 7.x too

CommentFileSizeAuthor
twitter_pull_cache_get.patch392 bytesdgsiegel

Comments

mcaden’s picture

mcaden commented
Status: Active » Needs review

I was beginning to notice the problem as well but hadn't dug into the code yet. Thanks!

I have D7 on the site I'm using this module for but I made the change manually and it worked perfectly.

irakli’s picture

irakli commented
Status: Needs review » Closed (fixed)

Committed to D6: http://drupalcode.org/project/twitter_pull.git/commit/9bf7c7a
Committed to D7: http://drupalcode.org/project/twitter_pull.git/commit/3e8b2b2

Thank you