When a query is extended it creates a new instance of the query object. This patch takes that into account.

CommentFileSizeAuthor
#3 webform_extend_querys-d7.patch1.54 KBquicksketch
webform_pager.patch782 bytesjames.elliott

Comments

james.elliott’s picture

james.elliott commented
Status: Active » Needs review
quicksketch’s picture

quicksketch
he/him
commented

Thanks James! Does this mean that we have the exact same problem just a few lines earlier when we extend the query for table sort?

    if (is_array($header)) {
      $pager_query->extend('TableSort')->orderByHeader($header);
    }
    else {
      $pager_query->orderBy('sid', 'ASC');
    }
quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Fixed
StatusFileSize
new webform_extend_querys-d7.patch1.54 KB

Here's a patch that makes the same change to the table sort extender and fixes the sorting on those pages. I've confirmed your patch works properly and I've committed this combined set of changes.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.