Sorry if this is something simple, but I'm baffled here. The comments for invite_form_alter say "the new mode is only allowed if no other module has overridden the menu access handler for the user registration form."
I did not make a note of it, but I don't think on initial install (and before I had done a run-through of the code) I had the "New user registration by invitation only" option in the user settings form. Which led me to install logintoboggan to try and achieve the redirect and login from the registration form.
This definitely alters the user_admin_settings form, so after going back to the code, I proceeded to uninstall logintoboggan, rebuild menus, etc. But I still see nothing of the form alters from invite. I am also not sure how to go about tracing any other modules which might be altering this form, though I don't suspect there are any.
First, is this a bug or did I just twist up the usage (and if so, how should I recover?)
And second, is this ideal behavior in terms of adding options to the form?

CommentFileSizeAuthor
#2 invite-registration-form-error-1068328-2.patch1.17 KBglekli

Comments

idiotprayer’s picture

idiotprayer commented

To clarify, the check function below is returning false, which results in the proper invite callback not being added to the user/register menu alter.
Line 244 of invite.module

/**
 * Determine if user registration mode is set to invite only.
 */
function invite_user_registration_by_invite_only() {
  return (variable_get('user_register', 1) === '1-inviteonly');
}
glekli’s picture

glekli commented
Status: Active » Needs review
StatusFileSize
new invite-registration-form-error-1068328-2.patch1.17 KB

I found that the 'invitation only' option did not show in the user settings form because the form slightly changed in D7, and the id of the fieldset that encloses the 'Who can register accounts' option is now 'registration_cancellation'. The code still referred to it as 'registration', which is the id used in D6.

I also noticed that the 'invite_process' function had been renamed to 'invite_process_invite', but hook_user_insert still tried to call the old function. That resulted in a 'Call to undefined function' error when I set the registration settings to 'invitation only' and tried to register as an invitee.

I am attaching a patch to fix these. This patch assumes that the patch in http://drupal.org/node/1144862 has already been applied to the 7.x-2.x branch.

paul_constantine’s picture

paul_constantine commented

I applied both patches you mentioned.

But still the Invite module does not work fully. It offers the option to set registration to "by invitation" in the account settings, it does send out invitations.

But when the invited person tries to register the page shows errors. And there is no button to proceed with the registration.

I did have the UR-invitation option enebled though.

Any ideas? Am I missing any other patches?

UPDATE -----------

Okay, I got it to work by disabling UR-Invite.

One problem remains though. Here it is.

  1. Let's say I invite Peter.
  2. Peter gets an email saying that he can create an account. Upon clicking on the enclosed link he can enter his name and his email address.
  3. Peter gets a welcome email and a "one-time-login" stating that he should change his passeword.
  4. Peter uses the "one-time-login" to log into the website. Upon clicking on account and edit Peter discoveres that he needs his old password in order to set a new password. Now what? Peter was never told his password to begin with.
  5. So Peter logs out and requests his password.
  6. All he gets are "one-time-login" links. Allways with no password.
  7. So Peter is stuck now. He can never set his password because the system will not tell him his initial password.

Am I missing something here? This is annoying.

glekli’s picture

glekli commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.