I just did a beta2 -> rc1 upgrade and my main aegir site wasn't put offline. I looked at the code quickly, and I suspect this is the case for all migrations.

In platform/migrate.provision.inc:

  drush_log(dt("Putting site under maintenance"));
  drush_set_option('site_offline', 1);
  _provision_drupal_create_settings_file();
  drush_invoke('provision-backup');

  <?php if (!$this->site_enabled) : ?>
    $conf['site_offline'] = 1;
  <?php endif ?>

I think we meant ->site_offline there, but that needs to be tested. Marking this as critical as it can result in dataloss if somebody posts content on the site after the backup is performed.

Comments

eugenmayer’s picture

eugenmayer commented

iam confirming this bug.

anarcat’s picture

anarcat commented
Status: Active » Needs review

I pushed a fixed to the master branch on git.drupal.org, please test master, then I will merge to 0.4, and we can make rc2.

I think this regression is related to #955018, because the "site_offline" variable wasn't propagated to the settings.php properly. I tried setting it in the site context (by using drush_set_option('site_offline', 0, 'site')) but that wouldn't work either. Oh and I tried of course that and using $this->site_offline in the settings.php - no luck.

I think that's becase site_offline is not a registered property of the site context... hence the relation with #955018: ability to save new arbitrary data to a context from outside the service.

anarcat’s picture

anarcat commented

@EugenMayer - can you test if you still have this bug now, with the latest code on git.drupal.org?

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Reviewed & tested by the community

I tested it and it works.

omega8cc’s picture

omega8cc commented

I see this change in the master on http://drupalcode.org but this commit is not listed on http://drupal.org/node/196005/commits which is rather confusing.

[EDIT] screenshots added:

The code: https://skitch.com/omega8cc/r1bjn/drupalcode.org-git-project-provision.g...

The list of commits: https://skitch.com/omega8cc/r1be4/commits-for-provision-drupal.org

anarcat’s picture

anarcat commented
Status: Reviewed & tested by the community » Fixed

alright, I merged the commit in the 0.4 branch - looks like we're mostly ready for rc2! :)

@omega8cc - i don't know what is the cause of that problem, but it has nothing to do with this issue. ;) i ping sdboyer about it though, we'll see...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit fa5f25b on dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x by anarcat: 
    #1068660 - disable the site during migration

because of #955018,...
  • Commit f91244a on 6.x-1.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x by anarcat:
    #1068660 - disable the site during migration

because of #955018,...