ok this is the weirdest bug I've ever met, since I'm migrating from aggregator2 I tried to retain fid's which meant that I have fids that look like 50000.

when visiting aggregator/sources/fid for high valued fid's I'd get an out of memory PHP error.

turns out the problem is the use of $feed['fid'] as pager $element in feedaggregator_node_list_items().

take a look at http://api.drupal.org/api/4.7/function/pager_load_array

this actually constructs an $element sized array which in our case would equal the fid.

now in my particular situation this is disastorous (imagine an array with 50K elements), but even for the normal case uneeded arrays of 200 elements is still too much.

so I guess you should stop using fid as pager $element, I'm not sure it's a smart idea to list all feeds each with their own pager on aggregator/sources either.

Comments

budda’s picture

budda
Primary language English
Location Cheshire
commented
Assigned: Unassigned » budda

The many pagers on a single page is a by-product of the feedmanager.module using the feed processors hook_list_items() function to generate 3 stories per feed.

I'll make a check to see if there's a limit specified to the hook_list_items() and if so, don't show the pager and instead show a 'read more' or similar link which will link through to the aggregator/sources/2 style pages.

budda’s picture

budda
Primary language English
Location Cheshire
commented
Status: Active » Fixed

Fixed in CVS.

alaa’s picture

alaa commented
Status: Fixed » Closed (fixed)

setting status to closed