Download & Extend

Conflicting messages from user_pass_submit

Project:Drupal core
Version:8.x-dev
Component:user.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:needs backport to D7

Issue Summary

Currently, if the password reset mail fails in user_pass_submit the user gets these two conflicting messages:

Unable to send e-mail. Please contact the site administrator if the problem persists.

Further instructions have been sent to your e-mail address.

Since _user_mail_notify provides a return value, we should check that before we print the second message.

Patch attached.

AttachmentSizeStatusTest resultOperations
user_pass_submit_message.patch1023 bytesIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch user_pass_submit_message.patch. See the log in the details link for more information.View details

Comments

#1

Status:active» needs review

Looks sane. Passing to testbed.

#2

Status:needs review» needs work

The last submitted patch, user_pass_submit_message.patch, failed testing.

#3

Status:needs work» reviewed & tested by the community

You patch is misformatted, you now have to generate it with the prefix, that's why your patch failed to pass the testbost.
Here is the attachment of the fixed patch (which is working great).

AttachmentSizeStatusTest resultOperations
user_pass_submit_message.patch1.01 KBIdlePASSED: [[SimpleTest]]: [MySQL] 35,969 pass(es).View details

#4

Version:7.x-dev» 8.x-dev
Status:reviewed & tested by the community» fixed

Makes sense.

Committed and pushed to 8.x and 7.x. Thanks!

#5

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here