Functional tests for payment

Sounds like a plan. In fact, you can spawn two child issues. One for adding and testing an example payment method for a redirected service. Another for adding and testing an example CC payment method.

Committed this.

A couple of things after reviewing this:

• User site_admin is not really needed for the tests, we could remove it from setUp
• The comment at the beginning refers to checkout tests.
• Do we need to do assertions in auxiliar functions as createOrderAndGoToPayment? I think that those assertions belong to checkout tests
• In testCommercePaymentCheckout you're asserting the validation for 2 or more chars long, so we are doing part of the validation of the pane in checkout tests and other part in the payment tests, we could do a test for both validations in payment test and take it out from checkout.
• We would want to test if the normal user is able to access the administration interface for payments, check last product ui tests.
• I think testCommercePaymentAdministration test should also do a test for a complete payment, not only partial
• $this->assertFieldByXPath("//input[starts-with(@id, 'edit-amount')]".. (and similar) could be just $this->assertFieldById('edit-amount' ...

Do we really need to keep assertions in each process?

I'm working in customer tests now and I'm going to include the generic "create order" with customer information filled in the commerce_base so we don't have to include it all over again (payment tests and tax tests include it and probably checkout tests can get benefit of this function as well), so there will be a commerce base test that ensures that the piece of code is correct, I'll update this issue as soon as we can include it.

With the new payment method access to administration test, we can get rid of the assertion in testCommercePaymentAdministration for 200 response (line 178)
and in testCommercePaymentMethodsAdministration (line 239)

I think we need to complete a payment, currently testCommercePaymentAdministration only "pays" half of the order total

Also we should create a helper module for offsite payments and test that the payment redirect happens, that the offsite button is present and so on.

I tested the replacement of assertFieldByXPath by assertFieldById and it seems safe even after the postAjax.

I pulled from your github repo for this branch (1069896) and I can see changes in #6 but not changes in #5, maybe you could take a look to this and put together the changes in a patch?

I've merged all the on-going tests in this issue #908302: Complete "version 1.0" of the CommerceBaseTestCase

Setting this to needs work as we need to create a helper module for offsite payments and test that the payment redirect happens, that the offsite button is present and so on.

Added new testing for offsite payment methods

Repo: git.drupal.org:sandbox/pcambra/1081200.git
Branch: 1069896
Diff: http://drupalcode.org/sandbox/pcambra/1081200.git/commitdiff/52033605dd5...

Does this need to stay in needs work mode? I've pulled those changes in, but we can further extend the tests by defining "remote" URLs in that module - i.e. page callbacks that redirect right back to the success or failure page to ensure the checkout workflow is correct. It doesn't really matter that we aren't actually redirecting to a URL on a separate domain, just that there's some sort of redirect and that we test a return that either simulates a customer cancellation, a failed payment, or a successful payment.