Closed (fixed)
Project:
Gallery formatter
Version:
7.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
23 Feb 2011 at 12:20 UTC
Updated:
4 May 2012 at 07:38 UTC
Jump to comment: Most recent file
Comments
Comment #1
manuel garcia commentedWe could do that, but then other people argue that:
And thus we never end this argument... I had to make a decision here, knowing that I would never satisfy everyone... sorry!
The only way around this is to make all this configurable, so that every use-case would be met, but that adds quite a lot more code, and makes the module heavier on sites.
If someone ever comes up with a clever, maintainable, and tested solution to satisfy all use cases, I'm willing to accept patches.
Comment #2
enkara commentedThank you for your answer!
Now I'm in a project I must finish, but if I can find time, I'll try to do something on this
Comment #3
topdillon commentedyou can hide that magnifying glass in css.
Comment #4
enkara commentedI know there are tricky ways to change things, but it's not the way to do it.
For now it's ok, but in the future maybe I'll try to do something if I find time, and I'll post it of course.
Thank you anyway ;)
Comment #5
minneapolisdan commentedDid anything come out this? I ask because looking at the demo, http://gf.ekhosting.net, it seems that clicking anywhere on the large image will bring up Colorbox. So far on my install, however, I can only get Colorbox to open when clicking the Magnifying glass (span.galleryformatter-view-full).
(note: we're using the latest Dev version)
Comment #6
manfer commented@minneapolisdan
Actually the demo site uses an older version of the gallery formatter library galleryformatter.js,v 1.1.2.4 that has not the prev, next arrows, nor the magnify glass, features. And the module itself is an earlier version that when clicking on the image opens the chosen modal -colorbox for the demo site-
Comment #7
manfer commentedI attach a patch that adds new configuration options to the formatter that allows to open the modal (full image) clicking on slide (the image) and to hide the view full image link (magnifying glass in default style).
Comment #8
testtest23112 commented@manfer
Thank you so much! Your solution works like a charm and is very flexible :)
Comment #9
graker commentedI tried the patch attached to #7 but it doesn't work for me (i have 7.x-1.0 version installed). I checked the "Open full image" box but it didn't work - nothing just happens when I click on the image. Though, the switch to the next image isn't happening also, which is good. I tried to clear all kinds of cache both Drupal and browser but it still doesn't work.
Also I noticed that even though I uncheck the "Show a view full image link", the magnifying glass still appears after a page refresh. And even more, when I come back to the field display settings, the checkbox for magnifying glass is magically re-checked again.
To be more specific, when I come to all fields display settings, I see "No full image link" in an image field settings summary. But when I click the gear to open display settings dialog, the checkbox is still checked there.
And if I totally uncheck the "Link slides to the full image" group, showing next slide when clicking on current slide appears to be broken.
Comment #10
manfer commentedThe patch has to be applied to development version 7.x-1.x
I'm going to change the version of the issue to avoid confusion.
Comment #11
graker commentedI applied the patch to dev version and it works. Thank you!
There is still a minor issue though: when viewing summary of field display settings, I see "No full image link", but in the settings dialog the checkbox is checked anyway. I guess, it has something to do with the form element default value.
Comment #12
Angelo Giammarresi commentedHi,
I am new to use Drupal and I don't know how to set this patch why do not update your version 7.x-1.x-dev including both patches this above and that about vertical images?
Otherwise, your module it's very nice and works perfectly with colorbox...I have another little issue, if my picture is wider than your big square it's clipped while in the thumbnail it's perfect...any chance to have a frame setting to adjust the main window, or how can I do it?
You can check this link to understand my problems...thank you, muchas gracias Manuel.
http://www.expo2015-italy.com/druped/node/20#
Angelo
Comment #13
manuel garcia commentedThanks much manfer for the patch, and thanks everyone for testing this.
I've managed to spend some time on this, and I agree it'd be a useful thing for people to use.
I've tested the patch above, and cleaned it up a bit. I've also made the option a bit differently, implemented it as a select list that lets you choose what method you'd like to use for linking to the full image.
It ends up a bit clearer, slightly shorter than the previous one, and in my opinion easier to figure out for the site builder (UX).
Please find it attached and test. Specialy test it out if you have a preconfigured field using galleryformatter, see if it breaks your current setup when applying it. We should be close to committing this. I want to get this in for the next release =)
Comment #14
manuel garcia commentedPlease disregard the last patch, forgot to remove a dpm() call.... try this one
Comment #15
manuel garcia commentedCommitted.
@manfer: I've given you authorship for the commit since most of the work was done by you. Thanks!
http://drupalcode.org/project/galleryformatter.git/commit/3a7052c