There are no classes on the tags in the list of addresses at user/%/addresses. This makes it incredibly difficult to target them with CSS.
This patch simply adds classes for the 'edit', 'delete' and 'add' links. Please let me know if it's suitable. Hopefully this should be good to go.
I was pretty shocked to see the HTML for the tables being constructed manually in these functions here. It should use theme_table() of course. I didn't fancy writing a patch for that one.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | themetable-1070592-1.patch | 4.63 KB | megachriz |
| uc_addresses-add-some-classes-ffs.patch | 1.29 KB | chriscohen |
Comments
Comment #1
megachrizHi chriscohen,
It sounds reasonable to have classes for the links, but I'm not sure if the table should be themed with theme_table(). It's not an usual table: it has no header for example.
I tried to implement theme_uc_addresses_list_address() using theme_table(), but the code needed for that turns out to be pretty complicated. Plus, every table row gets a 'even' or 'odd' class in that case, which is not needed here. It's even unwanted, because the following lines from the uc_addresses css-file got overwritten by tr.even and tr.odd definitions in the theme I was using:
Line 45 and 46.
Well, here is a patch that let theme_uc_addresses_list_address() make use of theme_table() so you can see how that would look like.
Comment #2
megachrizLinks on the address book page are made stylable in the 6.x-2.x version.
Note: this issue is related to #1103988: Please make the add address link stylable by giving it a class.