After going through an initial install of Media and WYSIWYG, including editing an input filter to enable the WYSIWYG support, it was not clear that the "Convert Media tags to Markup" option had to be enabled as I didn't realize that the module only inserted custom control tags and not raw HTML. Maybe changing the help message to say "This filter will convert [[{type:media... ]] tags into markup, necessary when using WYSIWYG plugins to embed media"?

CommentFileSizeAuthor
#1 media-n1070974.patch1.05 KBdamienmckenna

Comments

damienmckenna’s picture

Status: Active » Needs review
StatusFileSize
new1.05 KB

A quick patch.

JacobSingh’s picture

Status: Needs review » Needs work

I committed this, but also marking "needs work". This is our most common support request. What else can we do to ensure that peopel don't get bitten by it? should we just enable the filter on all input formats during install? Is that too invasive?

damienmckenna’s picture

Maybe also add a message during installation informing the site developer that it must be enabled per text filter before it really works? Maybe a reminder on the Media settings pages, or a list of text filters & a status indicating which ones have the input filter enabled, though I'm not sure what page that would go on?

JacobSingh’s picture

Yeah, I've long advocated that modules need "installer wizards" to go along with them for this kind of stuff... Hard to architect into the flow though. Do you think it's too invasive to just turn the filter on for everything except plain tesx? It won't really do any harm just being there I suppose.

agerson’s picture

I think something like this displayed after enabling the module would go a long way. Would that go in media_enable()? Happy to write a patch if you think its a good idea.

<?php
drupal_set_message('You must enable Convert Media tags to Markup on one of your input filters');
?>
oxyc’s picture

I'm actually for enabling the feature by default. I'm sure some people will be against it but the general community will be thankful for media module taking the initiative.

CinemaSaville’s picture

+1 for enabling it by default. Just had this issue, and I consider myself fairly savvy in this world now. God help the novices.

amateescu’s picture

Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Needs work » Needs review
Issue tags: +Media Sprint 2011

There's a related issue (with a patch) at #1238772-8: Disable the 'Media browser' WYSIWYG button until it has been enabled for the text format. Would that patch be enough to close this one too?

dave reid’s picture

Status: Needs review » Closed (duplicate)

Agreed, let's mark this as a duplicate.

dave reid’s picture

Status: Closed (duplicate) » Fixed

Better status.

Status: Fixed » Closed (fixed)
Issue tags: -Media Sprint 2011

Automatically closed -- issue fixed for 2 weeks with no activity.