Download & Extend
Javascript Aggregator » Issues

Add support for php_jsmin extension

Posted by GreenReaper on February 24, 2011 at 11:34am
Project:Javascript Aggregator
Version:6.x-1.5
Component:Code
Category:feature request
Priority:major
Assigned:Unassigned
Status:needs review

Issue Summary

The php_jsmin extension, being pre-compiled code, is likely to be significantly faster than the PHP-based JSMin even when using APC. Attached is a patch to enable its use.

AttachmentSize
javascript_aggregator.module.php_jsmin.patch2.3 KB
Login or register to post comments

Comments

#1

Posted by AntiNSA on March 2, 2011 at 6:45am

Anyone using this?

#2

Posted by AntiNSA on March 2, 2011 at 6:55am
Priority:normal» major

So, do you check the box for:

GZip JavaScript

Use php_jsmin instead of JSMin

Use JSMin+ instead of JSMin

aLL THREE, OR JUST ONE OF THREE , OR JUST GZ ZIP and php_jsmin?

Thanks for the help. Maybe good to put in readme

#3

Posted by mikeytown2 on April 2, 2011 at 2:11am

subscribe/hijack... #1109978: Add support for php_jsmin extension

Committed this code

#4

Posted by dougp on May 16, 2012 at 7:34am

I made my own version of this without realising that someone had already done it. I like my version better, it replaces the "javascript_aggregator_jsminplus" variable with a "javascript_aggregator_minifier" setting which allows you to select only one minifier.

  • jsmin
  • jsmin+
  • jsmin.so php extension

I think ideally though, the module would be extensible with some sort of hook to implement other minifiers/javascript processors, there are quite a few other ones out there.

AttachmentSize
0001-Add-support-for-ypass.net-s-conversion-of-jsmin-to-a.patch 5.03 KB