Site gone Wonky when enabling "Create New Revision" on Page Content Type

I cannot reproduce this on the last 5.x build.

Looks like the MySQL STRICT mode bug which has been fixed in the 5.x-dev version. Please test with that version or wait for the next release.

I'm getting this error on a clean drupal 5.1 install with:
Apache 2.2
PHP 5.2
MySQL 5.0.27

Details of the message:

user warning: Field 'log' doesn't have a default value query: INSERT INTO node_revisions (nid, vid, title, body, teaser, timestamp, uid, format) VALUES (1, 2, 'test', 'test', 'test', 1172018726, 1, 1) in C:\tools\Apache2.2\htdocs\drupal-5.1\includes\database.mysql.inc on line 172.

Steps to reproduce:
-Install drupal 5.1, create database, configure drupal, create user #1
-Create a page, check the "create new revision" checkbox before submitting
-Edit the page, check the "create new revision" checkbox before submitting
-Error appears, page is gone.

The log column is conspicuously missing from the insert statement, and does not have a default value (in the create table statement).

This is happening on 5.1.

All this is caused by the update to {node} table vid column and a failed insert of corresponding {node_revision} row.

Since the log column does not have a default value, it should always be inserted during an insert.

in node.module:

  if (!empty($node->log) || $node->is_new) {
    // Only store the log message if there's something to store; this prevents
    // existing log messages from being unintentionally overwritten by a blank
    // message. A new revision will have an empty log message (or $node->log).
    $revisions_table_values['log'] = $node->log;
    $revisions_table_types['log'] = "'%s'";
  }

When $node->log is empty, the $revisions_table_types['log'] will never get a value, thus it will never get inserted. I think you need to write a value all the time so it should have additional logic in an else block like this:

  else {
    $revisions_table_values['log'] = ''; // empty string value
    $revisions_table_types['log'] = "'%s'";
  }

I tested this with a page node.

Here is the patch against head. I'm not actually able to confirm whether it works in head which is why I will also attach a patch against 5.1 after this.

Here is the patch against 5.1

Sorry, my previous patch wasn't from root. Here is a patch from root against HEAD.

Can we remove the if statement and always do

    $revisions_table_values['log'] = $node->log;
    $revisions_table_types['log'] = "'%s'";

and modify the comment. It seems like an irrelevant holdover from before we refactored the revisions system.

Why not just modify the node_revisions table to accept null values for the log column?

Should I apply this patch to my 5.1 version? It's still coming up as an issue using Firefox and IE.

I think this was fixed long ago in 5.2 or 5.3 or some other 5.x release back in 2007. Shouldn't be a problem now.