If there are new comments in a thread/forum, the *new indicator only gets added if they're on the first page. It looks like the comment module notices the hit on the first page of the thread and inserts the correct text next to the new ones, but when you load the second page it thinks you've already viewed the entire thread (because of the hit to the node containing them) and removes them.

Did that make any sense?

Comments

ixis.dylan’s picture

ixis.dylan commented

Can anybody reproduce this?

It would be nice to get this and http://drupal.org/node/10664 fixed before 4.50, or it'll be released with a broken comment/forum system.

killes@www.drop.org’s picture

killes@www.drop.org commented

I can reproduce this here on drupal.org.

TDobes’s picture

TDobes commented

This might be tricky to fix... for anyone who's looking into it:

comment.module bases its "new" timestamps on whether a comment was posted before the last time a user visited a particular node. It uses the node_is_new function for this purpose. (The same logic is also used in comment_num_new). Thus, it is assuming that users view ALL of a node's comments when viewing the node.

To solve this, it looks like we'd have to track which comments each user has or has not viewed, as each user's comment viewing options could be significantly different. (i.e. sort order, comments per page, random access via. collapsed comments)

Anyone have any bright ideas on how to fix this without adding a lot of complexity or a rapidly-expanding db table?

moshe weitzman’s picture

moshe weitzman commented

dupe of 6371