Related to issue #965150: mailkey exclusion does not work at all.

Needs to be larger, in order to allow logintoboggan mailkeys. I suggest a minimum #maxlength of 512, or, ideally, it should be a multi-line text area.

I assume that newlines in the data (if we use a textarea) won't cause problems since we're splitting the config variable using preg_split in queue_mail.inc: $ignore_list = preg_split("/[\s,'\.\"]+/", variable_get('queue_mail_keys', ''));

Comments

mcurry’s picture

Status: Active » Needs review
StatusFileSize
new1.46 KB

I've attached a patch against the 6.x-1.x-dev archive (http://ftp.drupal.org/files/projects/queue_mail-6.x-1.x-dev.tar.gz)

Please review and comment.

mcurry’s picture

StatusFileSize
new679 bytes

Please ignore the previous patch, it was incorrect. Here's the correct one, applied against the 6.x-1.x-dev tarball:

mattcasey’s picture

Seems to work for me, thanks

mattcasey’s picture

steven jones’s picture

StatusFileSize
new679 bytes

Here's the patch from #2 for the testbot to look at.

Status: Needs review » Needs work

The last submitted patch, queue_mail-issue-1072232.patch, failed testing.

steven jones’s picture

Status: Needs work » Needs review
StatusFileSize
new662 bytes

Let's try that again.

steven jones’s picture

Status: Needs review » Fixed

Thanks so much, committed to 6.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.