Needs review
Project:
Contextual Administration
Version:
6.x-1.0-beta12
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
25 Feb 2011 at 12:52 UTC
Updated:
25 Jul 2012 at 07:14 UTC
Jump to comment: Most recent file
Comments
Comment #1
eclipsegc commentedWhat version of php are you using? (just for my graticification).
Eclipse
Comment #2
Mamoun commentedPHP 5.3.1 (PEAR)
Xampp 1.7.3
Comment #3
eclipsegc commentedCan you test on 5.2.4+? 5.3 is still unsupported by much of Drupal 6 contrib, including context_admin. With the advent of the new git vcs I do hope to get the time to start fixing these sorts of issues, but I suspect this is a php version issue.
Comment #4
Mamoun commentedDowngraded to 5.2.11 now, no more errors! Thank you very much for your help and for the great module. :)
I'm glad you pointed out the fact that some modules are incompatible with php 5.3, this might explains several unexplained errors I stumbled upon using some modules, so thank you again!
Comment #5
eclipsegc commentedHappy I could help. 5.3 is definitely a priority for me going forward, but only really for the 7.x branch (that I'll hopefully commit today some time) so... I'm glad you like the module I have great future plans I hope to implement :-D
Comment #6
caschbre commentedWhat part of that line is unsupported? I've come across the same issue and I'd love to help patch context_admin 6.x instead of having to roll back to a previous version of php.
Comment #7
christefano commentedcaschbre: I just started looking into this but at first glance it's because module_invoke() can't be used to pass by reference.
Changing status to "active". PHP 5.3 has been out since June, 2009.
Comment #8
eclipsegc commentedSo, 7.x has fixes for this, they just need to be backported. Essentially 6.x is utilizing the plugin system incorrectly, and when we use it properly, these issues go away.
Again I'll see if I can allot some time, maybe this weekend, to backport the 7.x fixes for this stuff.
Eclipse
Comment #9
jonskulski commentedEclipse,
Can you post to the patches you mentioned in case someone has time to port them.
Comment #10
jonskulski commentedJust some notes from investigating. Seems to be related to:
#647064: Fatal error: Unsupported operand types when menu_links query returns no results in system_admin_menu_block()
and a lot of modules are dealing with it:
#785930: Fatal error: Unsupported operand types
#595724: After core upgrade: Fatal error: Unsupported operand types ... /modules/system/system.module on line 627
....etc
For the record, I was trying to implement a page as a default local task. I switched the page to normal task and it went away. Which makes sense since that line
is essentially asking for a normal menu item.
Comment #11
eclipsegc commented@jonskulski
Thanks for running that down. I'll look into it more (work's had me totally slammed lately) but I think the answer is "replace this functionality with something custom" which is actually a topic that has come up in conversation a few times. I tried to just reuse core whenever possible and that has proven to be mostly impossible, so... I guess this instance shouldn't be a surprise.
Comment #12
decipheredPatch attached to fix the issue, checks to see if the value returned from the module_invoke is an array() before trying to += it. Alternative approach would be to enforce that an array is always returned.