Not only is this change confusing, changing the number of field wipes out anything you already entered.

Preview Availability was changed to Limit Lists to Available Items after feedback from several stations that didn't understand that clicking that limited the items in the list to items available at the time entered. How would anyone know "Number of Selected Items" did that?

In addition if I start with 10 fields and need an 11th item, adding the field wipes all the previous items I selected.

CommentFileSizeAuthor
#1 Screen shot 2011-02-25 at 7.52.52 AM.png26.98 KBkreynen

Comments

kreynen’s picture

StatusFileSize
new26.98 KB
darrick’s picture

I'll do some more work on this after I figure out how to use git. I've been trying to follow the docs here: http://drupal.org/node/331941 for proper ahah callbacks. I found it easier at the moment to parse a selector as opposed to figuring out the current number of items and that they should be incremented. But I'll figure out a way.

As for the "Limit Lists to Available Items", my idea is to put that button in for non-js clients. For js clients I'll update the select lists when the reservation dates are changed.

I'm not able to reproduce the issue about current selections being wiped out when additional selectors are added or removed.

kreynen’s picture

This may be an issue with jquery_update. When it's installed, I get RangeError: Maximum call stack size exceeded errors in Safari... but only in Safari. I will do more testing.

darrick’s picture

I fixed the first part of this issue: http://drupalcode.org/project/merci.git/commit/0ad1037

Will work on the update according to reservation date next.

darrick’s picture

Status: Active » Fixed

Fixed the error for "Limit Available Items" not showing up: http://drupalcode.org/project/merci.git/commit/159b886

Adding a ahah handler for the date_combo to do this was too hard and impractical.

If you still have trouble with the third issue please resubmit that separately.

Status: Fixed » Closed (fixed)
Issue tags: -merci_rc

Automatically closed -- issue fixed for 2 weeks with no activity.