This issue is part of meta issue #1931088: [META] Fixing tests

I added this address to a node
------
xx Rue Grande
Anhee 5537
Belgium
xx° xx' xx.7328" N, xx° xx' xx.7968" E
-----
the [ See map: Google Maps ] is not showing. it does show OK for Netherlands, USA so far but not for Belgium.

Thanks

Comments

acarpio’s picture

If you check on the configuration for Location, on Map links, Belgium is "none supported". What I did for Spain, also none supported, was to copy the code from location.uk.inc and pasted it on the location.es.inc file replacing all the "uk" appearances with "es" and the "uk google sites" with the "es google sites". That worked for Spain.

youssefr’s picture

I see!
That is a great solution, now will this work with Drupal 7 as well?

Thanks

Youssef

Jerome F’s picture

Version: 6.x-3.x-dev » 7.x-3.x-dev
Status: Active » Needs review
StatusFileSize
new873 bytes

like this ?

Jerome F’s picture

Status: Needs review » Needs work

it doesn't work as is
maps.google.co.be doesn't exist

acarpio’s picture

You need to look for the right url. I think it is: http://maps.google.be/

Jerome F’s picture

StatusFileSize
new889 bytes

thank you that solved the problem, please review and if it's all right please commit, because for me it works.

ankur’s picture

Status: Needs work » Fixed

Thanks for the patch. Committed to 7.x-3.x and 7.x-4.x.

youssefr’s picture

Thanks you very much.
Youssef.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

gillesv’s picture

Seems incorrect to me. The patch uses the URL "maps.google.co.be". The co should not be there, as the URL http://maps.google.co.be does not exist.

It should be http://maps.google.be

jdanthinne’s picture

I confirm that.
The patch hasn't changed all the links…
return ('http://maps.google.co.be?q='. urlencode(implode(', ', $query_params)));
has still to be changed to
return ('http://maps.google.be?q='. urlencode(implode(', ', $query_params)));

jdanthinne’s picture

Status: Closed (fixed) » Needs review

Reopening the issue then…

joericapens’s picture

StatusFileSize
new309 bytes

Patch file for convenience.

tngvndrm’s picture

+1

joericapens’s picture

Status: Needs review » Reviewed & tested by the community

Please commit the last patch so this issue can be closed.

It's a trivial fix; http://maps.google.co.be doesn't exist, http://maps.google.be does.

podarok’s picture

Status: Reviewed & tested by the community » Postponed

postponed before tests fix
#1931088: [META] Fixing tests

podarok’s picture

Status: Postponed » Needs review

#1931088-3: [META] Fixing tests mostly fixed for 7.x-3.x branch
this one needs review

Status: Needs review » Needs work
Issue tags: -See map: Google Maps

The last submitted patch, location-fix-be-google-url.patch, failed testing.

podarok’s picture

Issue summary: View changes

Updated issue summary.

bebop-design’s picture

Issue summary: View changes
Status: Needs work » Closed (duplicate)