Adding a CTools dependency for the UI and exportables would reduce the amount of code you have to maintain. Working on a patch now.

CommentFileSizeAuthor
#11 wordfilter-exportability-1073026-11.patch31.79 KBq0rban
#9 wordfilter-exportables-1073026-9.patch29.68 KBq0rban
#4 wordfilter-1073026-4.patch16.59 KBq0rban
#3 wordfilter-1073026-3.patch16.27 KBq0rban
#2 wordfilter-1073026-2.patch16.4 KBq0rban
#1 wordfilter-1073026-1.patch16.4 KBq0rban

Comments

q0rban’s picture

q0rban commented
Status: Active » Needs review
StatusFileSize
new wordfilter-1073026-1.patch16.4 KB

Patch attached. I'm not sure how helpful this is though, as I'm thinking people would probably rather export a whole language, not individual words. Not sure the best way to implement that yet though.

q0rban’s picture

q0rban commented
StatusFileSize
new wordfilter-1073026-2.patch16.4 KB
q0rban’s picture

q0rban commented
StatusFileSize
new wordfilter-1073026-3.patch16.27 KB

Darn, accidentally uploaded the same file. ;)

q0rban’s picture

q0rban commented
StatusFileSize
new wordfilter-1073026-4.patch16.59 KB

Added support for disabled items.

csevb10’s picture

csevb10 commented

Ok. I admit that I made your life (or mine) a little more difficult, but now that I've separated out admin functionality into a separate file, getting your patch to apply to the latest code might be harder than just writing it from scratch. :-/ If you can re-roll a patch based on the re-work of the code that I did, I would love to add exportable functionality.
Regardless, this functionality is definitely on my list of features to develop moving forward, so if you don't have time, I will get to this as soon as time allows.

q0rban’s picture

q0rban commented

Hmm, I was working off of the latest in the 7 branch when I made my patch. Is there a separate branch I should be working from?

csevb10’s picture

csevb10 commented

You did everything correctly, I just happened to be making changes at the exact same time to a lot of the same code, so pulling all of your changes into what I did became very difficult. Does that make sense? If you can roll off the current d7 branch, it'll just make life easier, otherwise, I'll get to this myself as soon as I can.

q0rban’s picture

q0rban commented
Assigned: Unassigned » q0rban
Status: Needs review » Needs work

Ok, I'm going to try to re-roll this patch, and also make it exportable by language. This will mean I'll have to increase the language support a bit.

q0rban’s picture

q0rban commented
Status: Needs work » Needs review
StatusFileSize
new wordfilter-exportables-1073026-9.patch29.68 KB

Here's a new patch, made with git format-patch. The language stuff is in a separate commit, so if you don't want that to be included with this work, you can separate it out, and we can create a new issue for that (or post to the existing one for 6: #265565: Multilanguage support (at least for 6.x)).

To apply this patch:

git checkout 6a6a8bb1f6158b1238e51fb94686e2a93fbec360
git checkout -b wordfilter-exportables
git am wordfilter-exportables-1073026-9.patch
# If you don't want the language commit, run this:
#git reset HEAD~1 --hard
# Otherwise, proceed with merging this into development.
git checkout 7.x-1.x
git merge wordfilter-exportables --no-ff
q0rban’s picture

q0rban commented

Actually, the language portion is going to need work, as caching needs to be updated to be on a per language level.

q0rban’s picture

q0rban commented
StatusFileSize
new wordfilter-exportability-1073026-11.patch31.79 KB

Updated patch to fix caching as mentioned in #10. It will be harder to separate out the language stuff from this patch, so let me know if you need a hand with that.

adamtong’s picture

adamtong commented

how to use this? also, the bulk add is not working.

there is error:

Fatal error: Call to undefined function _wordfilter_language_options() in /mydrupal/sites/all/modules/wordfilter/wordfilter.admin.inc on line 62

mxh’s picture

mxh commented
Issue summary: View changes
Status: Needs review » Closed (outdated)