Download & Extend

Webform needs to flush Entity Cache after updating components (and e-mail configurations)

Project:Webform
Version:7.x-3.9
Component:User interface
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Building a new webform with 7x.3.7. Each time I add a new component, it does not show up until I clear my site cache.
I have all caching turned off as well for devel.
At first I thought the form elements were not even being added but as a hunch cleared the cache an "POOF", there it was!

By the way. Can I add my voice to full token replacement would be totally cool, snazzy and da-bomb?

Comments

#1

I'm not sure why this behavior would exist and I'm not seeing it on my local installation. If you can provide more information on how to reproduce this issue it would be appreciated.

Regarding tokens, please keep that conversation to the relevant issues:
#1001798: Rewrite token replacement system to use D7 tokens
#428982: New hooks for additional token replacements

#2

I've also been running into this. When a user adds a new component to the webform it won't appear until the cache has been cleared. I do receive the following warning when adding a component, though I don't know if it is related.

Notice: Trying to get property of non-object in node_page_title_pattern_alter() (line 39 of /sites/all/modules/contrib/page_title/modules/node.page_title.inc).

#3

I did a little investigating and this problem is due to the Entity Cache module. This module is recommended for use with Display Suite, which is why I have it installed and this is likely the case for MrPhilbert as well. The easy fix is to simply disable the Entity Cache module and use Display Suite without it, but it would be nice for these modules to play nicely together.

I'm not too familiar with the Entity Cache module myself, but the following function call might be able to flush out the entity cache after a component creation.

entitycache_flush_caches()

#4

Thank you kovalchik. I do have display suite enabled. I'll disable entity cache and see if that does the trick. If so, I'll report back.

#5

Thanks for the updates guys. I'm glad to know what's causing this problem.

#6

Title:Webform Cache» Webform needs to flush Entity Cache after updating components
Version:7.x-3.7» 7.x-3.9
Status:active» fixed

I've committed this patch which clears the Entity Cache cache table upon adding/removing/updating/reordering components.

AttachmentSize
webform_entitycache.patch 2.07 KB

#7

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#8

Status:closed (fixed)» active

3.9 has been working great for me, thanks for committing that patch. However, it looks like this is still an issue when adding a new recipient email. The email will be added to the system but won't actually show up until the cache is cleared. Disabling Entity Cache solves the problem so it seems this is directly related to this issue.

Thanks for all your hard work on this, I know it's kind of a pain to deal with module incompatibilities. We use Webform on nearly every site we build and I'm still amazed by how much it can do.

#9

Thanks kovalchik. This probably should have been a new issue but I appreciate the report.

#10

Oops, sorry about that. I'll make sure to open a separate issue next time.

#11

Title:Webform needs to flush Entity Cache after updating components» Webform needs to flush Entity Cache after updating components (and e-mail configurations)
Status:active» fixed

I've committed this patch which clears entitycache on e-mail configuration insert/update/delete.

#12

The committed patch.

AttachmentSize
webform_email_entitycache.patch 2.03 KB

#13

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.