Meta tag simple

please check existing module metatags_quick
Wanna join efforts?

sorry, didn't see your comment regarding metatags_quick
Do you consider an option of joining efforts with the metatags team?

Hi,
I have downloaded and reviewed your code. Several conclusions/thoughts:
1. Grouping of meta fields to one vertical tab looks nice. In most (if not in all) cases people would want the whole bandle of tags, so it's logical to place them together.
2. API that you have chosen (node_* hooks) suits only for nodes, while entity API used in metatags_quick works with all entities. Also, I've got SQL exceptions when I tried to enable meta tags for one of existing content types. So I think storage engine should be based on fields, not on single table.
3. I suggest to think how it's possible to combine vertical tabs with fields of type meta.

What do you think?

Stumbled on this while trying to clean out the queue. Sorry it's been sitting here so long. Here's a review. It all looks very close, and will be fine with a few changes.

Please remove the $Id$ tags, as we don't use them any more.

You don't need the empty hook_install() and hook_uninstall() functions in D7 any more I don't believe. Thought that issue was resolved anyway.

There are a number of trivial trailing whitespace issues. Consider using an editor or other tool that will clean those up for you according to the Coding Standards.

        '#description' => t('A concise explanation of this page. Used by search 
        engines and other sites to describe it in listings. A major search engine 
        confirms that a good description can improve clickthrough rate. Limit 
        length to around 155 characters, plain text, no HTML.'),
      );

You have t() around long formatted/wrapped text. This will be murder for translators, even if it probably comes out OK in the html. Probably best to just make it a line.

Some indentation issues in the .module file. Consider using an editor that will fix all those for you.

I'm not suggesting that you shorten it. I'm suggesting you make it all one line, or at least not introduce whitespace.

If you have a string to be translated like
$x = t('some
text
like
this');

it works fine in HTML, but remember that this will have to be translated. So it becomes impossible for translators to search for or work with. Because they're searching for the literal string, which now has returns and spaces in odd places.

So the options are:
$x = t('some text like this');

but I know that's unwieldy in the code

$x = t('some
text
like
this');

Would at least not introduce the random whitespace in the translated string (but still has annoying returns)

And finally you *could* concatenate all the stuff and then run t() on it, but t() is generally supposed to be for static strings.

Hope this is making some sense.

OK, works for me. Thanks so much for your patience and cooperation!

Please remove the CRs from the README. You'll want to use an editing environment that doesn't add those, in most cases.

OK, no objections, so Git vetted user role granted. Thanks for your many ongoing contributions.

Please review other people's submissions so we can get this queue down.

Thanks so much for your patience and your present and future contributions.