Include $flag object & $status in API calls [#1073664]

Hi,

Working on a module to provide basic Rules module integration for Flag Friend (http://drupal.org/sandbox/thomjjames/1073654). It's working pretty well but it would be great if the module_invoke_all('flag_friend') calls included the $flag object & $status variable too.

My main reason for requesting this is so the Flag Friend Rules module can grab the user messages (mainly on "request" & "approve" calls) from the flag_friend_message database table and pass it as an argument to rules if it's available. Please correct me if there is already a way to do this :)

Patch to follow
Thanks
Tom

Comment	File	Size	Author
#2	api-addition-1073664-3.patch	1.72 KB	thomjjames

Comments

Comment #1

thomjjames commented 26 February 2011 at 07:06

Status:

Active

» Closed (fixed)

Just grabbed the 6.x-2.x version and the $flag object is indeed included in the API calls & $status isn't strictly needed.
Will provide patch against 6.x-1.x version instead.

Tom

Comment #2

thomjjames commented 26 February 2011 at 07:07

Version:	6.x-2.x-dev	» 6.x-1.x-dev
Status:	Closed (fixed)	» Needs review

Status	File	Size
new	api-addition-1073664-3.patch	1.72 KB

Here's a patch against 6.x-1.x-dev if 6.x-2 version never makes it to the light of day.

Cheers
Tom

Comment #3

sirkitree commented 26 February 2011 at 07:19

Status:

Needs review

» Fixed

Thanks! Looks fine, committed.

Try to use git diff --relative --no-prefix in your patches so they apply just a little cleaner. With the a/ and b/ format, anyone applying the patch has an extra step of specifying the file.