Closed (fixed)
Project:
Token Filter
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
26 Feb 2011 at 14:27 UTC
Updated:
16 Jun 2011 at 01:31 UTC
Jump to comment: Most recent file
Comments
Comment #1
bellHead commentedPatch attached ...
Comment #2
bellHead commentedSetting the status after uploading the patch would probably help :)
Comment #3
toxiclung commentedthis is great! please commit to dev release :D
Comment #4
mattbk commentedSuperscribe.
Comment #5
gregglesThis should be applied to the token_filter.module instead of token itself.
Comment #6
dave reid@greggles: I actually really like the idea of starting to transition this to core (and just providing the filter itself) in token.module. Especially considering how small amount of code it is. :)
Comment #7
gregglesI don't think a filter makes sense for token.module nor core.
The results of filtered text are cached. That makes them a poor match for tokens which are meant to create dynamic replacements.
Or at least it makes the use case for this filter _very_ specific which makes me think, again, it's not suitable for a module like token that is on thousands of sites nor core.
Comment #8
altavis commentedsubscribing
Comment #9
dave reidHrm, the filter is disabled by default and won't affect any sites. I think it would be good to start really experimenting with token filters since it's a very critical functionality missing from Field API.
Comment #10
dave reidWhat if we merged token_filter as a sub-module of token.module?
Comment #11
gregglesWhat's the problem with keeping it separate and linking to it from the project page?
Comment #12
pvhee commentedboth options (#10 and #11) are fine for me. If anyone wants to step up as comaintainer that would be great since I have few time to follow this up
Comment #13
dave reidYeah I guess that seems fine. I imagine we'll start heading towards more token integration with Field API in D8, which will require it to work with input formats, so it seemed reasonable to merge seeing as token is the testing ground to move into core.
@pvhee: Since I'm already interested in token filtering, I don't mind helping if you need a co-maintainer for the port.
Comment #14
melandren commentedSubscribing
Comment #15
dave reidPort has been committed and released as 7.x-1.0.