The module adds an 'edit domain content' permission, but the documentation, and the rest of the code in the module, refers to the 'edit domain nodes' permission. As a result, users with 'edit domain content' aren't allowed to edit content on their assigned domains.

Comments

agentrickard’s picture

Same is true of the 'delete domain content.'

/me blames the core terminology change..

agentrickard’s picture

Status: Active » Needs review
StatusFileSize
new578 bytes

This patch will also need an update hook.

yrro’s picture

Status: Needs review » Active

I did a find and replace of all 'edit domain nodes' strings in the domain and domain_content modules, changing them to 'edit domain content' and permissions seem to work as I expect. I did the same for 'delete domain nodes' -> 'delete domain content'.

The 'affiliated content' list now has the following warning at the top. I will file this as a separate bug if you like.

Notice: Undefined index: -1 in domain_content_check() (line 135 of /srv/www/drupal7.red-redemption.com/drupal-7.0/sites/all/modules/domain/domain_content/domain_content.module).

yrro’s picture

Ah, changing it back would also fix the problem. I assumed the renaming was deliberate! :)

agentrickard’s picture

Status: Active » Needs review

The renaming doesn't matter much, now that title is separated. But fixing code may be easier than an update hook for end-users. Revising patch.

The other is a separate bug.

agentrickard’s picture

StatusFileSize
new10.21 KB

Patch try #2.

agentrickard’s picture

Status: Needs review » Fixed
StatusFileSize
new20.4 KB

Patch that includes a docs fix.

agentrickard’s picture

Needs an update hook, too, for those coming from D6.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.