I have build a UI switch for a platform to make it a VCS build if needed. Looking at the code of platfom/verify.provision.inc

According to the docs of drush_backed_invoke http://api.freestylesystems.co.uk/api/drupal/contributions--drush--inclu... the third arguments is not the options array, but the second. Thats why working-copy is never working.

CommentFileSizeAuthor
#3 workingcopy.patch687 bytesEugenMayer
#1 workingcopy.patch677 bytesEugenMayer

Comments

EugenMayer’s picture

EugenMayer commented
StatusFileSize
new workingcopy.patch677 bytes
Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs work

Your patch seems cut off, it shows $o instead of $options.

EugenMayer’s picture

EugenMayer commented
StatusFileSize
new workingcopy.patch687 bytes

Urgs, sorry. Patch reattached.

EugenMayer’s picture

EugenMayer commented
Status: Needs work » Needs review
anarcat’s picture

anarcat commented

Hi - thanks for the heads up. I committed a fix in the master branch, care to test this again?

http://drupalcode.org/project/provision.git/commitdiff/ba08581dd1718214c...

If it works, please mark it as RTBC so I will merge this in the stable branch.

Thanks in advance!

EugenMayer’s picture

EugenMayer commented

Well i have tested it already on my branch, so i guess no need to test it again ( in my case i tested it alone with this patch + rc1 ) and also with all of my fixes + this one. Worked without issues.

If thats enaugh, i set it to RTBC, just give me a hint

anarcat’s picture

anarcat commented

I didn't apply your patch, but a reimplementation that doesn't use array_merge(), that's why I have requested testing.

EugenMayer’s picture

EugenMayer commented
Status: Needs review » Reviewed & tested by the community

tested the patch, works fine

joestewart’s picture

joestewart commented
Status: Reviewed & tested by the community » Fixed

Anarcat merged this into the stable branch - http://drupalcode.org/project/provision.git/commit/16f40383cc4da29c9dc8a...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit ba08581 on dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x by anarcat: 
    #1074414 - fix calling sequence on drush_make
  • Commit 94e9cf7 on 6.x-1.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x by anarcat:
    #1074414 - fix calling sequence on drush_make