In webcam.module, there are two occurences of link_validate_url() which should, instead, be changed to webcam_validate_url().

CommentFileSizeAuthor
#5 0001-Fix-link_validate_url-reference.patch1.98 KBrmontero

Comments

moonray’s picture

moonray commented
Status: Active » Fixed

Good catch. Obviously I'm borrowing some code from link module. :)
Fixed in Git.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

MtRoxx’s picture

MtRoxx commented

Interesting, I just hit this issue with the current (Jan 29, 2012) download.

rmontero’s picture

rmontero commented
Priority: Normal » Major
Status: Closed (fixed) » Active

Hey moonray,

I can confirm what Mt_Roxx said. I too see this still.

Also, if it is an exact replica why not do something like: https://gist.github.com/2504372 where you have your function use link_validate_url if module_exists('links') == TRUE and fall back to valid_url otherwise. This would be only if you really don't want to create a dependency to the links module, which would be the other workaround.

If you want I can contribute that as patch.

rmontero’s picture

rmontero commented
StatusFileSize
new 0001-Fix-link_validate_url-reference.patch1.98 KB

Here is a patch with my proposed fix.

sjpatrick’s picture

sjpatrick commented
Status: Active » Reviewed & tested by the community

I have reviewed and tested this patch and find that it addresses our problem just fine.
I would really like to get this patch moved into the main branch.