Site aliases aren't added to DNS zone

This patch add/delete CNAME records to DNS zone.

I'll see what I can do. We should add records for alias only if zones already exist and are managed by Aegir or we should create new zones ?

I tried to add records for aliases on different zones with this code :
$this->config('zone', $zone_alias)->record_set($sub_alias, array('A' => $ips));

Even if the variable $zone_alias reflect a different zone name, records are always added in the zone of website. I tried to disable the cache for zone config with no result. I could generate a different zone by changing the context with d(@server_master) but this command causes many problems.

My knowledge of the inner workings of Provision is too limited to be carried out this work. I publish my work here if someone wants to continue.

Patch reviewed and committed in development branch dev-dns_alias_records-1074966.

I have tested the patch with the install of example.com with 3 aliases : www.example.com, example.fr and www.example.fr. We should have two zone files but there is only one, example.com. You can see the files generated:

"config/dns.d/example.com.zone.inc"

$record[''] = array (
  'A' =>
  array (
    '@server_master' => '172.16.206.129',
  ),
);
$record['@'] = array (
  'A' =>
  array (
    '@server_master' => '172.16.206.129',
  ),
  'SOA' =>
  array (
    'serial' => '2011041301',
  ),
);
$record['www'] = array (
  'CNAME' =>
  array (
    0 => 'example.com.',
  ),
  'A' =>
  array (
    '@server_master' => '172.16.206.129',
  ),
);

"config/server_master/bind/zone.d/example.com.zone"

; Bind zonefile
; File managed by Aegir
; Changes here may be lost by user configurations, tread carefully
$TTL 86400
@     IN     SOA  ubuntu admin.ubuntu.localdomain (
                  2011041301 ; serial
                  21600; refresh
                  3600 ; retry
                  604800 ; expire
                  86400 ; minimum
          )
@   IN  NS  ubuntu. ; primary DNS
@   IN  NS  debian.localdomain. ; slave DNS
@   IN  A   172.16.206.129
    IN  A   172.16.206.129
www IN  CNAME   example.com.
www IN  A   172.16.206.129

You can see that all aliases are stored in the same file, even if provision shows creating example.com zone and creating example.fr zone.

I changed the behavior of the function config() of provisionService class to store multiple instances of provisionConfig_dns_zone and manage multiple zone files.
--
http://drupalcode.org/project/provision.git/commit/8834a5543f007f12f60ef...

Yes it's an API change. Even if I was careful to not break other services officially maintained, services developed by third parties may have problems in two cases.

Configuration classes are registered like this:

$this->configs['server'][] = 'provisionConfig_example';
$this->configs['server'][] = 'provisionConfig_example2';

Before the last instance was returned, now this is the first.

Service uses the data parameter of the function config() several times in the same script: before the function returns the same instance, the function now returns two different instances.