Closed (fixed)
Project:
Slideshow Creator
Version:
4.7.x-1.15
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
8 Jan 2007 at 01:39 UTC
Updated:
11 May 2007 at 12:21 UTC
I'm not sure if this should be a bug report or a feature request. But currently, people with CCK installed are advised to display slideshows by calling slideshow_creator_process_text() directly. The problem, though, is that this seems to eliminate all Java functionality! Looking at the code, I notice that slideshow_creator_process_text() doesn't even attempt to do Java.
Can you make it possible so that people who have CCK installed can still create a Java-based slideshow? This could be done either by modifying slideshow_creator_process_text() or by giving us good syntax for calling slideshow_creator_display() directly [if that's even possible].
Thanks in advance!
Comments
Comment #1
brmassa commentedTreesong
sorry for the waiting... your description seems to me a javascript error coz the new code really adds teh .js file. On Internet Explorer, the older code seems to crash or stop running.
i just posted a new update. it basicly corrects the javascript bug that firefox and konqueror (browsers that i use most) dont crash.
i ask you to try and give me a feedback.
best regards,
massa
Comment #2
Treesong commentedI installed the new version, and it's not working. It does indeed give Java errors this time, so those may be helpful for you to see. [I dislike Java coding and thus couldn't make heads or tails of the error messages.]
Here's the page that I've got it on:
http://raceactivist.org/Gallery/
Right now, it doesn't even bring up the HTML version of the slideshow. [That's what it used to do when I was using the previous version of the Slideshow Creator.] Instead, the JS error kills the slideshow entirely, and the body of the page looks blank (aside from Drupal heading/sidebar/etc).
One odd thing is that if I do it as you describe in the instructions:
I get a PHP error:
Fatal error: Only variables can be passed by reference in /home/content/r/a/c/raceact/html/includes/common.inc(1180) : eval()'d code on line 2In order to avoid this error, I have to do a two-line process, along the lines of:
This ends the PHP error, but then it gets us right into the JS error. I tested it in IE, Mozilla, Firefox, and Safari, and none of them displayed it successfully. In the previous version, the above code (plus the <?php and such, obviously) actually worked to get it at least as far as the HTML version of the slideshow. [I think I may have had to throw an "echo" in front of the "slideshow_creator_process_text();"] But in the updated version, it goes straight to the JS error. [I'm guessing that it detects JS-ability, then attempts to use JS, then fails entirely, thus not displaying HTML version.]
Please let me know what you think ASAP. An HTML slideshow is passable, but I'm doing this for a client, and they would prefer the fancy auto-transitions.
Comment #3
Treesong commentedIn case it helps, here is the exact PHP code I'm testing with currently, though I've tried a few different configurations of the details:
Comment #4
brmassa commentedTreesong
you are completely write! And the reason was simple: i tried to optimize the code but i forgot the CCK users. heheh sorry.
i tested again using PHP (i must warn that HTML filter and Slideshow Creator filter cannot be activated coz they will try to modify the [slideshow: ...] before)
i ask you kindly to test and report back!
best regards,
massa
Comment #5
Treesong commentedThe PHP problem appears to be solved. However, the original JS problem still seems to be in place. When I view the page, it gives me errors in the web browser's Java console -- something along the lines of:
Any idea what the problem may be? I've tried it in numerous browsers with similar results -- though some browsers don't have a good way to view the Java console b/c they are l@m3 :)
Comment #6
Treesong commentedAny luck yet figuring out what the Java problem is? I've tried it on multiple browers, and the slideshow still isn't working.
Comment #7
Treesong commentedActually, now that the PHP is fixed, it seems to be a problem with the syntax of my Slideshow Creator command. I'm following the instructions for syntax, but the sample command works, and my command doesn't. If I can track down the exact problem, I'll post something more here. In the meantime, I'm going to replace the sample syntax with my text step by step to see where the problem may lie...
Comment #8
Treesong commentedOkay... so the Slideshow is *kinda* working now, but it's encountering a few glitches depending on which browser I view it in. So far, I've tested it on the following (Mac OS 10.3.9 version of these):
* Mozilla 1.7.13: It mostly works, but the Blend number doesn't seem to do anything. It just blends from one slide to another in about a second's time regardless of this value.
* Safari 1.3.2: It does a very smooth fade-out, but then before the new slide appears, it flashes the old slide for a moment, then replaces it with the next slide (no fade). [It also seems to wait longer -- is it adding together the Rotate Plus Blend times even though it's not effectively Blending?]
* Firefox 2.0.0.1: Actually works rather well.
* Internet Explorer 5.2: It rotates, but doesn't seem to blend. Just sheerly judging by time, I think that it too is attempting to blend, but not succeeding. It just waits longer, then blinks from one slide to the next.
You can see my use of it at:
raceactivist.org/gallery
It's working well enough that my client will be pleased... but even so, if there's any way to smooth it out, that would be even better. :) Thanks in advance!
Comment #9
brmassa commentedTreesong,
1* i was testing for the very first time the CCK module... it appears to accept normally filters! well, if its right, slideshow creator wont need any special thing on CCK nodes. i did a very simple test, so i will try some other soon.
2* im planning to review all problems mentioned, but i will travel tomorrow. Here in Brazil, friday will start the national holiday called Carnival (lasting till next wednesday), so next week i promisse you to look on these.
3* thanks a lot for keeping all this bug reports.
regards,
massa
Comment #10
brmassa commentedComment #11
killes@www.drop.org commented