Should/could function _html_for_buttons be a theme-able function?

I'm facing an issue right now with Modal Frame API, http://drupal.org/node/946146 , where when editing a node in a modal frame Multiselect's add and remove buttons get the "target=_new" appended, and thus open empty windows/tabs when clicked.

The solution put forth by the maintainer of Modal Frame API is to add the class: "modalframe-exclude" to links that should not be modified in this way by Modal Frame API, and thus my request. I've tried to add the class via JavaScript, but I can't seem to modify the links before Modal Frame gets to them.

Also, and this is minor, I notice that the following lines in multiselect.module both the add and remove buttons are given the same id.

/**
* Provides html to display the buttons on the form.
*/
function _html_for_buttons($fieldname) {
$buttons_code = "

";
return $buttons_code;
}

Comments

wishywig’s picture

wishywig commented

Apologies for the formatting in my original post:

/**
 * Provides html to display the buttons on the form.
 */
function _html_for_buttons($fieldname) {
  $buttons_code = "<ul id=\"multiselect_btns\">
<li class=\"multiselect_add\" id=\"". $fieldname ."\"><a href=\"javascript:;\">Add</a></li>
<li class=\"multiselect_remove\" id=\"". $fieldname ."\"><a href=\"javascript:;\">Remove</a></li>
</ul>";
  return $buttons_code;
}
mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes
Status: Active » Postponed (maintainer needs more info)

multiselect-6.x-1.7 is no longer supported, because Drupal 6 is no longer supported.

Can you confirm if this is still needed in multiselect-2.0.0-beta4?

I'm going to mark this issue as "Postponed (maintainer needs more info)"... but when you answer, please change it back to "Active". If I don't hear anything back in 6 months, then I will mark this issue as "Closed (outdated)". Thank you in advance for your understanding and patience as I try to keep this module's issue queue clear.