error when importing item from discogs

I don't know why Drupal isn't auto-generating the -dev (HEAD) version... I assumed it had something to do with the Git migration, but now I'm not sure...

In any case, that's an odd error. I've never run across it before. It sounds like Discogs is passing Drupal an array for something like artist or title or something.

Which album were you importing? It might help me track that bug down.

Also, is this with every album, or just one or two?

Dammit. OK, I'll take a look at it. Hopefully I should have a patch later today.

That's a pretty serious issue, so I changed the priority to "major."

I cannot for the life of me recreate this bug. The errors are happening in db_escape_string(), but I'm not calling that function in my code. I'm sure it happens somewhere when Drupal writes data to the database... but the API page doesn't have the call hierarchy, so I can't follow it back to where it's going wrong.

I'm going to need a lot more info from you, I'm afraid.

• What image handler are you using? Does switching image handlers fix the issue?
• Does this happen only when importing albums, or also when you create albums by hand?
• When did you first start getting the error?
• Have you applied any of the patches from this issue queue?
• What other modules are installed? Activated?
• I'd like any info you can give me about the environment - exact Drupal version, OS of the webserver, etc.

Any clues you can give me would be helpful. Frankly, I'm stumped.

I'm betting that this issue is related to #1152738: label, catalog field import issue. Funny that I never ran across it before, though.

Details are in that issue... I'm not entirely sure it's the same cause, though. I'll try to fix that issue, and we'll see if it fixes this one as well. If it does, I'll mark this one as a duplicate.

I fixed the other issue, #1152738: label, catalog field import issue. The fix is in HEAD, and there's a patch in the other thread. I believe, but don't know for sure, that it should fix this issue as well.

Can you test and confirm? I was never able to replicate this bug.

I still can't replicate this bug at all, so I'm kind of in the dark here.

The only thing I can think of is a change to _discogs_trim. I added code to make sure the string was actually a string and not an array.

I just pushed it to 6.x-1.x-dev, but it probably won't show up here for a while (patches can take 24 hours to propagate). In the meantime, I've provided a patch.

Still, I'm not entirely convinced this is the problem, as this function is mostly called when you're adding a release by hand. The only other place I could see this happening is in theme_discogs_forminfo, which uses check_plain and check_markup. However, I have code there to double-check that those are not arrays.

If that's where it was happening, the error would occur whenever you're seeing a checkbox-list of the albums, artists, etc. to import. Is that where it's occurring?

Okay, I did some work on the two functions that I suspect were causing problems. I've included a patch. Please test this and see if it works.

I also changed the function to trim fields to length. If anything is different now because of that, please let me know. It shouldn't be, so if there is something different, that might be a clue as to why it's throwing those errors.

After re-writing for Discogs API v.2, I'm closing this issue as fixed. Re-open if it happens again.