Projects should have "master" renamed to appropriate branch [#1076616]

We don't seem to be able to test branches that don't have a proper 6.x or 7.x branch name.

Discovered on #1076584: Branch tests fail on Privatemsg master.

I recommend that we just go through the 90+ testable projects and fix the branches. 'master' should not be used anywhere that testing is turned on.

Also, probably *all* branches are being currently tested for no reason, and failing.

Comment	File	Size	Author
#4	testable_projects_using_master_for_dev.txt	3 KB	rfay

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

boombatower CreditAttribution: boombatower commented 28 February 2011 at 22:24

Comment #2

rfay

English

Palisade, CO, USA

CreditAttribution: rfay commented 28 February 2011 at 22:29

The other implication of this... The hook that submits branch tests on commit needs to be more selective about what it tries to test.

Comment #3

eliza411 CreditAttribution: eliza411 commented 11 May 2011 at 18:16

This is something I could probably help with. Do you have a list of the 90+ testable branches and a procedure in mind for working with the module maintainers?

Comment #4

rfay

English

Palisade, CO, USA

CreditAttribution: rfay commented 24 June 2011 at 16:25

File	Size
testable_projects_using_master_for_dev.txt	3 KB

Comment #5

eliza411 CreditAttribution: eliza411 commented 26 June 2011 at 23:45

Project:	Drupal.org infrastructure	» Git on Drupal.org
Component:	Git	» Tests
Assigned:	Unassigned	» eliza411
Category:	bug	» task

Comment #6

eliza411 CreditAttribution: eliza411 commented 28 June 2011 at 01:12

Comment #7

eliza411 CreditAttribution: eliza411 commented 28 June 2011 at 01:13

Lame ... I did not mean for that to be a tag.

Comment #8

eliza411 CreditAttribution: eliza411 commented 29 June 2011 at 13:33

Got another handful posted today. I should be able to finish this evening.

Comment #9

eliza411 CreditAttribution: eliza411 commented 30 June 2011 at 04:08

Assigned:

eliza411

» Unassigned

And there's a post in every queue.

Comment #10

boombatower CreditAttribution: boombatower commented 30 June 2011 at 20:48

I am still kinda curious as to why this is the case. Last I remember the PIFT code detects the core version using the taxonomy on the release node...as it should. Depending on the branch name is silly. Is there something else I am not remembering?

Having the branches renamed makes sense since that is the new standard, but the testbot being the reasons seems a bit off.

Comment #11

boombatower CreditAttribution: boombatower commented 30 June 2011 at 20:49

Confirmed the code:

    // Attempt to determine the Drupal core API version.
    $api = array();
    foreach ($branch->taxonomy as $tid => $term) {
      if (in_array($tid, $api_versions)) {
        $api['version'] = array_shift(explode('.', $term->name, 2));
        $api['tid'] = $term->tid;
        break;
      }
    }

Comment #12

boombatower CreditAttribution: boombatower commented 30 June 2011 at 20:51

If anything based on reading some of the reported problems this was stale branch records as I mentioned during the change. Aka a commit needed to be made to resend the release information with the updated branch (aka HEAD -> master).

Comment #13

rfay

English

Palisade, CO, USA

CreditAttribution: rfay commented 30 June 2011 at 20:52

The reality is I don't remember the outcome or context of #1076584: Branch tests fail on Privatemsg master

Comment #14

boombatower CreditAttribution: boombatower commented 30 June 2011 at 20:56

Title:

All testable projects should have "master" renamed to appropriate branch

» Projects should have "master" renamed to appropriate branch

Not that it's a big deal, but based on #13 seems like this may have just been a transitory problem.

Comment #15

sun

German

Karlsruhe

CreditAttribution: sun commented 7 July 2011 at 00:04

Nevertheless, this initiative is probably worth to continue. Putting code and naming branches after core compatibility sounds like the only proper standard all of contrib should adopt.

Comment #16

boombatower CreditAttribution: boombatower commented 7 July 2011 at 00:13

Completely agree.

Comment #17

peterx CreditAttribution: peterx commented 21 November 2012 at 04:40

The pages you see when setting up a sandbox do not have a definitive statement about this issue. There is a page that pops up in searches saying you should create a new branch then delete the master branch. Renaming sounds more logical and efficient.