Machine-name node types should use underscores.
All node type underscores in URLs should be dashes.
We have lots of str_replaces to turn underscores from machine-readable to dashes in URLs.
But, we're missing a dash to underscore for hook_help, per the new 'help' index of hook_node_info.

The end result is
http://www.example.com/node/add/casetracker-case (the right URL, but with no help).
http://www.example.com/node/add/casetracker_case (the "wrong" URL, but with help).

This patch adds a simple dash to underscore check in node_help, which allows help on both URLs.

Personally, I'm not a fan of all this str manipulation.

CommentFileSizeAuthor
_underdashhelp.patch628 bytesmorbus iff

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Reviewed & tested by the community

Confirmed with a content type called "wiggle_widget" (don't ask ;)). Before patch, my Submission guidelines text didn't show up; after patch, it did. The "blog" content type kept its help text.

RTBC.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Reviewed & tested by the community » Fixed

COmmitted to HEAD>

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)