domain_views: Patch to allow more flexibility in rendering Domain ID field [#1078056]

I have rolled a patch with code updates to the file domain_views/includes/domain_views_handler_field_domain_id.inc.

The patch allows the Domain Source to be rendered as an ID, a site name or a subdomain. Previously subdomain wasn't an option.

Attached is the path, and also some screenshots of the *new* way. The project I rolled this patch for is the home page of http://www.sacramentoinsights.com. We use it to render a list of subdomains on the site.

Comment	File	Size	Author
#2	better-domain-source-id-rendering-1078056-7x.patch	4.65 KB	noahlively
	patch-3.PNG	22.53 KB	noahlively
	patch-2.PNG	23.95 KB	noahlively
	patch-1.PNG	78.44 KB	noahlively
	better-domain-source-id-rendering.patch	4.03 KB	noahlively

Comments

Comment #1

agentrickard

he/him

English

Georgia (US)

commented 2 March 2011 at 14:29

Project:	Domain	» Domain Views
Version:	6.x-2.x-dev	» 7.x-1.x-dev
Status:	Needs review	» Needs work

This looks pretty handy.

New features go in 7.x.

The plain $text return needs to be sanitized. How does it affect existing uses?

Comment #2

noahlively commented 2 March 2011 at 17:37

Status	File	Size
new	better-domain-source-id-rendering-1078056-7x.patch	4.65 KB

OK here is a patch for 7.x-1.x-dev.

I sanitized $text through a call to check_plain().

This patch has built in backward compatibility with previous versions. The keys/values of the $options array are slightly different, but logic in the options_form() function will check for legacy values and re-save them in the new format.

Comment #3

agentrickard

he/him

English

Georgia (US)

commented 2 March 2011 at 19:26

Status:

Needs work

» Needs review

Super-awesome.

Any independent reviewers out there?

Comment #4

agentrickard

he/him

English

Georgia (US)

commented 2 March 2011 at 21:27

Title:

domain_views: Patch to allow more flexibility in rendering Domain Source ID field

» domain_views: Patch to allow more flexibility in rendering Domain ID field

Works very nicely in D7.

Comment #5

agentrickard

he/him

English

Georgia (US)

commented 3 March 2011 at 14:19

I took another look at this. We already have domain fields that cover these options. What does this patch offer that isn't already covered?

Is there a benefit to this extra render element? Better queries?

Comment #6

noahlively commented 3 March 2011 at 21:22

Without the patch I created, if a node is mapped to more than one affiliate domains I get duplicate records showing up in my views output.

I tried using the Domains: Subdomain field.... but that outputs the active subdomain, not necessarily the source domain of the node.
Domain Source doesn't provide a subdomain option (until this patch)
If I add a relationship to the source domain, then add the field "Domains: Subdomain" using the newly added relationship, I one row per affiliate domain mapped to the node.

Example:
mysite.com
a.mysite.com
b.mysite.com

Node 321 is mapped to mysite.com and a.mysite.com, with a.mysite.com as the source domain. Using technique #3 above, I get duplicate records.

Does what I am saying make sense?

You can view the output (after patch was applied) at http://www.sacramentoinsights.com. The home page renders a list of subdomains with links to the subdomains.

Without the patch, there was no way I found to work around the duplicate record issue after spending hours looking.