Upgrading D6 Deco theme to D7

Looks very nice. Thanks Komal.

Problem one (same problem as in D6 I believe): when a block does not have a title set, the background of the block title is still shown and taking space.

Problem two: the Drupal 7 toolbar items uses the Deco theme bullets. We need a way to remove the bullets from the toolbar.

I have not tested all combinations of the theme layout, but it's working as expected for my tests.

Will you apply to be a maintainer or co-maintainer for this theme?

Problem one and two are fixed, thank you very much.

I would suggest you to apply to be the maintainer of this theme. Currently no one is an active maintainer, although a few people still have permission to maintain this module, a fresh maintainer would be great.

You would be able to commit the Drupal 7 version of the theme and work in the issue queue with the help of other users of this theme.

Will you consider being a maintainer?

i tried it and realized that there is a gap on the right side. maybe it's a css problem. Opera,Chrome,Firefox and IE is the same. i attached a picture.

can you take a look at this problem?

@metality: I cannot reproduce your problem. Which browser are you using? Also, did you have the same problem with Drupal 6 and Deco 6.x-1.1?

The idea is to see if the problem you are experiencing was there in D6 or if it came up while doing the D7 version.

@xmacinfo thank you for your answer. my browser is opera but i tried firefox,chrome and ie. it is the same gap. but in Drupal 6 and Deco 6.x-1.1 there were no problem.

can you try it:
http://www.ozgurhayal.com

@metality: OK, now I see it. There is a an horizontal scroll bar larger than the viewscreen. When scrolling to the right, we see the gap. If we don't scroll, there is no gap, but the horizontal bar is annoying.

I have the same problem here.

This is indeed a CSS issue, but I was not able to pinpoint the problem with Firebug yet.

@komal.savla: Working perfectly without any horizontal scrollbar.

Good luck on co-maintainership.

@komal.savla thank you for fixing but there is still a gap on the right. it became smaller(maybe 2 or 3 px) but still there. i tried it in opera,chrome,firefox and ie. but maybe i can try to fix it myself and inform you.

@komal.savla: A few more problems.

Navigation menu items in the right sidebar are not using the correct font colors, margin and various list bullet images. For example the right pointing arrow is black instead of using the subtle Deco gray one.

Primary menu items are using ALL CAPS instead of all lowercase letters. Also, the menu is flushed to the right of the viewport instead of vertically aligning with the right side of the right sidebar. Looks like margin is missing to the right of it's displayed in the wrong div.

The highlighted item block looks like using to much margin or padding compared with D6 version. I migrated a simple mission block using a simple text line.

@komal.savla: Thanks for the quick fixes.

Navigations menus are now displayed correctly.

Primary menu is now showing with the correct fonts and proper position, which, by the way, should correct metality issues with the theme (when the last menu item was active, a gap of a few pixels was created).

As for Featured regions and some other small display issues in the footer, I will double check and come back with a better explanation. But it's very minor.

Thank you for the hard work!

@komal.savla: Here are the explanations for the few fixes still needed.

Feature region
The features sections have the text too large and padding/margin in extra. When upgrading from D6 to D7, the mission is moved to that region.

• The font for the text is a bit too large (d6 uses the body value, d7 uses #featured .block .content).
• d7 inject a p tag, since it's now a block, while d6 mission used plain text (unless the admin added his own HTML).
• That paragraphs add to much margins.
• The "#featured .block" ruleset should have margin and padding set to 0, again to be more like d6.

Obviously, since Featured is now a region, you might choose to leave the Featured region as is.

Footer region
In the footer, the footer message should float to the right, making both menu and message on the same line.

So the “div.region.region-footer” should float to the right. :-)

@komal.savla: This is interesting and that make sense. I will play more with the theme and add other blocks in both regions and see what can be done.

Moving to Fixed for now.

Actually it's better RTBC until the maintainer creates the release.

This is fixed since komal.savla created the 7.x-1.x-dev version.

Followups have their own issues.