New install. Not an upgrade issue.
Before install, the following menus setting was intentionally not used/configured, found at:
admin > structure > menu > settings >
Source for the Secondary links: [No Secondary Links]
Installed Domain module according to documentation and without error.
Enabled "Domain Access".
Then enabled "Domain Configuration" and get the following error appearing on the modules list page:
#Notice: Undefined index: in domain_conf_domainbatch() (line 418 of /var/www/html/sites/all/modules/domain/domain_conf/domain_conf.module).
Line 418 of that file references the source for secondary links. After changing the secondary links setting to anything other than "no secondary links" the error on the modules list page goes away. But a new error appears on the menu settings page:
#Notice: Undefined index: in menu_configure() (line 682 of /var/www/html/modules/menu/menu.admin.inc).
It seems that whether or not a source is selected for secondary links, one of the above errors is generated, but neither exists simultaneously. These only happen when "Domain Configuration" is enabled. It doesn't seem that Domain Config should be dependent in any way of the secondary links source, especially if unused.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 1078266-domain-conf-menu.patch | 1.67 KB | agentrickard |
| #4 | 1078266-domain-conf-menu.patch | 1.26 KB | agentrickard |
Comments
Comment #1
ununpentium commentedUpon further testing, the error...
Notice: Undefined index: in domain_conf_domainbatch() (line 418 of /var/www/html/sites/all/modules/domain/domain_conf/domain_conf.module).
...continues to regenerate on the module list page after enabling any other module, so long as Domain Configuration remains enabled.
Comment #2
ununpentium commentedFor what it's worth, I've been able to remove the above errors with this quick admin-side fix:
1) Disable the "Domain Configuration" module (if it is already enabled).
2) Disable the "main menu" and "secondary menu" from the theme settings page (admin > appearance > settings > yourdefaulttheme)
3) Set the source for the Main links and Secondary links to anything other than "no main links" and "no secondary links", respectively (admin > structure > menu > settings)
4) Then enable the "Domain Configuration" module.
The undefined index errors no longer appear.
Comment #3
agentrickardNice report. I had seen this behavior on upgrades, but not on new installs.
It's a problem with the default variable for primary/secondary links.
Comment #4
agentrickardSimple fix for the first notice.
I suspect the other error is a core bug. Investigating:
Comment #5
agentrickardThe second error is a core bug, which I copied into Domain Conf. See #983746: Menu settings - Source for the Main links when empty results in undefined index + broken #description.
Comment #6
agentrickardRevised patch which updates the upgrade instructions (which had been noted but not identified this problem.)
Comment #7
agentrickardFixed. You need the core patch, too.
Comment #8
ununpentium commentedThanks. Fix confirmed on my end.