I have created new module and its need to be review by you.
Following is details of module
Introduction of Foursqure
Foursquare is a location-based mobile platform that makes cities easier to use and more interesting to explore. By “checking in” via a smartphone app or SMS, users share their location with friends while collecting points and virtual badges. Foursquare guides real-world experiences by allowing users to bookmark information about venues that they want to visit and surfacing relevant suggestions about nearby venues. Merchants and brands leverage the foursquare platform by utilizing a wide set of tools to obtain, engage, and retain customers and audiences.
Module Information
Basically the module is designed for getting latest tips,venue name and image from fouresqure.com and it is designed as Block.
What is Module Requires?
1) Latitude and Longitude of location
2) Access Token Key from fouresquire.com. This will get after registration on foursqure.com
Comments
Comment #1
mermentau commentedI don't think you are supposed to assign yourself. You will need a link to your sandbox here.
Comment #2
drupal.spadeworx commentedHow to link sandbox project?
can you tell me?
Comment #3
mermentau commentedYou need to create a project and commit it with git. That will give you a sandbox project and you can link to it in a reply here. Look at others in the Project Application issue queue for clues. http://drupal.org/project/issues/projectapplications?categories=All
Comment #4
Snugug commentedChanging from Major to Normal. Once you get some code committed we can review it.
If you are here requesting that this module be created, this is not the place for that. Drupal.org Project Applications is a place for people who have written code to apply to get contributor access to Drupal.org, aka getting permission create a project at drupal.org/project/%name.
Comment #5
drupal.spadeworx commentedHello,
Here is my sandbox project link. Please review it and let me know
http://drupal.org/sandbox/drupal.spadeworx/1077186
Comment #6
drupal.spadeworx commentedHello,
Here is my sandbox project link. Please review it and let me know
http://drupal.org/sandbox/drupal.spadeworx/1077186
Comment #7
ultimateboy commentedI didn't actually install the module, just started to review the code.
First and foremost, you should try to adhere to the coding standards as closely as you can. It's hard to read the code given it's spacing is off in a number of areas. See http://drupal.org/coding-standards for more information.
Your variables and function names should all be prefixed with "foursquare_tips".
I probably wouldn't include your foursquare api token in the committed code. I'd instead make that variable begin blank and present a warning to the user that they need to configure the module.
You no longer need any of the
// $IDstuff that CVS required.I'm not really a fan of how you included the css as it can't be changed. Include it in a way that a theme could override it.
$tipDate=time_ago($timestamp);in your template file should probably be moved to a preprocess function.The HTML itself in the template could probably use some work, this is list data, so perhaps a
<ul>is more applicable.This module solves a subset of what is actually needed. Ideally, we begin work on a very generic foursquare api module, which simply wraps all of the foursquare api calls so that modules like this can be created easily and simply. But what you've done looks like it works and that shouldn't be forgotten... Fix up a few of the spacing and naming issues and I think you'll be good to go. Thanks.
Comment #8
gregglesA few more items:
LICENSE.txt should be removed
And then you should address everything in http://drupal.org/node/1117996#comment-4420650 and other comments on that issue since it is a copy of this module's code.
It's been nearly a month since Ultimateboy provided feedback without a response.
Comment #9
drupal.spadeworx commentedHi,
We have stopped all Open Source work and do not wish to continue supporting this module anymore.
Regards,
drupal.spadeworx
Comment #10
gregglesI'm sorry to hear that, drupal.spadeworx, but thanks for the update.