sandbox: link
repo viewer: link
please refer to TAG:: 7.x-1.x-dev

This module allows users to login on a Drupal website through the Facebook and Hyves – using their Facebook or Hyves login and password.

The module also brings other extra features:

  • Admin can allow user profile fields update with Hyves and Facebook data
  • Admin can configure field mapping and customize login buttons

Differences from other modules:

  • Standalone (not need any libraries)
  • Flexsible
  • Small and simple

Comments

d.olaresko’s picture

d.olaresko commented
Status: Active » Needs review

Just switch status

d.olaresko’s picture

d.olaresko commented

Dev version updated. Fix few bugs.

d.olaresko’s picture

d.olaresko commented
Status: Needs review » Active

Just switch status

Oleksandr.Masovets’s picture

Oleksandr.Masovets commented

Tested.
Nice module!

d.olaresko’s picture

d.olaresko commented

main brunch updated to last stable version

sreynen’s picture

sreynen commented
Status: Active » Needs review

Krasnyj, I'm not sure if your "Tested" means "reviewed & tested by the community" or not. If so, please change the status. If not, this should be "needs review", since that's what people doing reviews generally look at.

Oleksandr.Masovets’s picture

Oleksandr.Masovets commented

It means that i have tested this module.

rteijeiro’s picture

rteijeiro commented
Status: Needs review » Needs work

Please, add a README.txt file describing the module installation, requirements and features.

d.olaresko’s picture

d.olaresko commented

README.txt added

d.olaresko’s picture

d.olaresko commented
Status: Needs work » Needs review

Forgot to switch status =)

rteijeiro’s picture

rteijeiro commented
Status: Needs review » Needs work

Sorry, but I have clonned your git project and I still can't see the README.txt file.

Also you should add the same information to the sandbox project page ;)

Please, try to review your project with the Coder module. It need some fixes.

Kind regards.

d.olaresko’s picture

d.olaresko commented
Status: Needs work » Needs review

README.txt added to all branches (master branch had no readme).
Project reviewed and fixed with Coder module

rteijeiro’s picture

rteijeiro commented

Ok. Nice work!!

Now I have to test the module with a Facebook and Hyves API keys.

Kind regards.

d.olaresko’s picture

d.olaresko commented
Component: new project application » module

Did you tested it? any suggestion?

arcaneadam’s picture

arcaneadam commented
Status: Needs review » Needs work

Can you explain what the differences between your module and some of the many other "login with" modules are. Just doing a search for Hyves I found http://drupal.org/project/serviceconnect which seems to do exactly the same thing your module does. Not to mention there are already numerous modules out there that can connect via FB.

It seems that this is potentially a duplicate module.

d.olaresko’s picture

d.olaresko commented
Status: Needs work » Needs review

arcaneadam, Service connect created for drupal 6 (and have no Drupal 7 branch. Social Connect is for Drupal 7) and it was posted at April (I created Social Connect module at march so I had no information about it). Also Service connect provide field mapping for short list of fields and use third party libraries (oAuth). Social connect provide full field mapping (you can map almost all fields from Hyves and Facebook) and have no third party libraries (It use JS Connectors from Hyves and Facebook).

For Drupal 7 we can provide this functionality only with modules:
1. FBConnect (http://drupal.org/project/fbconnect) and Drupal for Facebook (http://drupal.org/project/fb) - Both works only with facebook. Both has unstable Drupal 7 version amd requires Facebook PHP SDK. Also they have no field mapping.
2. Janrain Engage (http://drupal.org/project/rpx) - Powerful stuff but use thirdparty service. Have alot limitations with free account on Janrain Service
3. Gigya (http://drupal.org/project/gigya) - Almost the same as Janrain Engage.
4. OpenID Selector (http://drupal.org/project/openid_selector) - Nice module but have no field mapping.

That`s all. For now there is no other projects that provides this functionality.

Hope this short review can help.

P.S. Sorry for my English. English is not native language for me =)

Regards, Dmitry aka DOlar4ik.

voxpelli’s picture

voxpelli commented

Seems like this functionality would be best suited as patches for either my own module http://drupal.org/project/connector or http://drupal.org/project/serviceconnect - the two which we have already discussed merging in http://drupal.org/node/1117088

Fragmenting this module space even more would not benefit anyone in my opinion. Since I maintain one of the "competing" modules I will let it be up to others to do the review of this request though.

arcaneadam’s picture

arcaneadam commented
Status: Needs review » Needs work

I'd agree with voxpelli that merging this work as patches with existing modules would be the best result here. voxpelli I think the best course of action here is that you and dolar4ik connect and see what work can be done to combine his functionality with your existing module. From there if you feel that he could be a good potential co-maintainer then the git application process could be easier for him.

MGParisi’s picture

MGParisi commented

Both of the above modules connector or serviceconnect do not have stable releases for 6.X, and have not been worked on for over a month. Sorry, but I would support a 7.x module. It sounds like the two module owners of serviceconnect and connector may want to patch this module (as per http://drupal.org/node/1117088) to meet there needs when/if they decide to move to 7.x

Ultimately forking a project is not up to committee, its up to the authors.

voxpelli’s picture

voxpelli commented

@MGParisi: To defend myself a bit: Connector hasn't been updated to D7 due to me having to port OAuth to D7 first for it to be useful. The D7 OAuth port is currently a work in progress on my computer which will be pushed soon. When OAuth has been ported I will start the port of Connector. The reason Connector is still in alpha is because I think it needs more feedback and features to become complete - a stable release should be a truly stable release and not just a number that looks good.

MGParisi’s picture

MGParisi commented

I don't think you need to defend yourself. I am very happy to see everyone contribute, and want to support all thoose that do. Voxpelli, I am really great full for your work. I also understand people are busy, and wish more people had more time.

mlncn’s picture

mlncn commented
Status: Needs work » Fixed

This was reviewed and tested several comments back. The point of these reviews is actually to assess the developer more than the particular module, and Dmitry has demonstrated he can be a module maintainer.

Dmitry, you can now promote projects from Sandbox to full status-- that doesn't mean you have to for this one. You seem to have a good grasp on the space but so of course does voxpelli. I would urge you to look again at merging or being a submodule with the D7 version of the (merger of the) active modules, with everyone having commit access. If not try to explain on the project page the technical reason that similar modules exist.

Some additional code cleanup to know about in any case:

- No need for $Id$ anymore.
- Drupal 7 uses the more concise "Implements hook_xyz()." language.
- All comments, including inline ones, should have Sentence case and end with a period.
- in your .info, no files[] should be listed unless there is an object class that needs registering there (this changed during Drupal 7's development)

When you would like further review for any module please do ask at http://groups.drupal.org/peer-review/requests

benjamin, agaric

d.olaresko’s picture

d.olaresko commented

mlncn, thx for your comment. I will work on it.
Cheers.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.