I am just trying resolve a random bug so decided to run some modules through the Coder module to eliminate that as a possible issue. Saw few issues with the D7 version that would be great to get into an upcoming release.

Comments

petsagouris’s picture

petsagouris commented
Status: Active » Fixed

Well apart from the "@file missing" occasions there are a couple of other formatting recommendations.
This is what the latest from git gives,

SITES/ALL/MODULES/CUSTOM_DEV/ADMIN_MENU/ADMIN_MENU.INC

  • Line 219: missing space after comma
    list($function,) = each($function);
  • Line 691: Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)
    drupal_set_message(t('Enabled these modules: !module-list.', array('!module-list' => implode(', ', $saved_state))));
  • Line 704: Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)
    drupal_set_message(t('Disabled these modules: !module-list.', array('!module-list' => implode(', ', $devel_modules))));

    • I consider these to be non-essential. In fact I think this issue needs to be closed

mgifford’s picture

mgifford
he/him
Primary language English
commented

Thanks for checking this through & verifying that the 691 & 704 have been properly sanitized.

The comma's & spaces are annoying. Wish Coder just ran through and gave a patch where it thought there should be comma's & spaces that could be easily applied. Definitely non-essential, but getting rid of the comma on line 219 would be better as it's not needed.

I expect this is a big improvement from March when I did the testing, but am really not sure. Coder's been changing slowly too which is good.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.