Hi! I've made a very simple patch for video_filter module to support issue.com embedding (and iframe embedding in general).

The problem with issue.com (and some other services) is that it needs some magic document_id for embedding its flash-viewer with object tags, which we can get only through issue.com API. So you can't embed issue.com documents with just URL.

But on a bright side, you can get a flash movie from them, which can easily be embedded via iframe tags, just by adding ?mode=embed at the end of URL.

So I've made a very simple patch to video_filter module, which adds the first iframe-embeddable codec to codecs array and adds some generic functions for iframe-embedding to video_filter "core". :))

Is someone interested in that stuff? It's kinda very simple, so I'm not sure, is it worth it to make a nice looking patch and upload it here. Maybe it's author's choice to avoid iframe-embedding support... :))

Comments

bachan’s picture

You can see an example of issuu.com movie embedded via iframe with video_filter module here:
http://www.diy-zine.com/zines/zatknis-0

It's DIY noise punk magazine from Belarus (in case, that you're wondering).

santam’s picture

Hi Please do tell us how to do this. I have been scratching my head about how we can use this to display scribd and issu files. Scribd is particularly important for us as it can be used to display a lot of different file types. All in all a iframe based solution will improve the applicability of the video filter.

bachan’s picture

StatusFileSize
new2.52 KB

Hi! The patch to support issuu.com embedding with iframe tag is attached. You can patch your video_filter-6.x-2.7 version by:

tar -xzvf video_filter-6.x-2.7.tar.gz
cd video_filter
patch -p0 < /path/to/video_filter-6.x-2.7-issuu-support.patch

You can support scribd and any other iframe-embedding by writing your own function in video_filter_issuu()-style, e.g. returning video_filter_iframe() result, but not video_filter_flash() result. Any questions are welcome here or by email (ba4an@yandex.ru). I'm not php developer in general, though.

bachan’s picture

And thanks for killer embedding solution for drupal! Your video_filter rule! :)

blackdog’s picture

Version: 6.x-2.7 » 6.x-3.x-dev
Status: Patch (to be ported) » Needs review
traviscarden’s picture

Title: Is someone interested in issue.com patch and iframe embedding in general? » Add support for Issuu
Version: 6.x-3.x-dev » 7.x-3.x-dev
Assigned: bachan » Unassigned
StatusFileSize
new1.33 KB

Here's a new patch that takes advantage of the video_filter_iframe() function to create the iframe. The regex is also a little more flexible about accepting query strings in the embed code. (The publication I tested with added ?mode=window&backgroundColor=%23222222, which should be preserved.)

traviscarden’s picture

Status: Needs review » Fixed

Committed to 7.x-3.x and 6.x-3.x. Thanks!

traviscarden’s picture

Status: Fixed » Postponed

Oops. Our approach turned out to be naive: the Issuu API is somewhat more robust. I'm going to try to work with the company to come up with the best solution.

minnur’s picture

Issue summary: View changes

Any update here ? The codec doesn't work. Their URL patterns have changed.

minnur’s picture

Status: Postponed » Closed (won't fix)

Closing this for now. Feel free to re-open if you have working patch.